bpo-29176: Fix name of the _curses.window class #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set name to "_curses.window" instead of "_curses.curses window" (with a space!?).
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
+ Coverage 82.37% 82.37% +<.01%
==========================================
Files 1427 1427
Lines 350948 350948
==========================================
+ Hits 289093 289098 +5
+ Misses 61855 61850 -5Continue to review full report at Codecov.
|
briancurtin
approved these changes
Feb 12, 2017
|
Serhiy Storshaka asked me if the change can have any impact on pickle. No, it doesn't because these objects were not picklable before and are not pickable after ;-) |
Mariatta
referenced
this pull request
in Mariatta/cpython
Mar 7, 2017
Set name to "_curses.window" instead of "_curses.curses window" (with a space!?). (cherry picked from commit 61e2bc7)
vstinner
pushed a commit
that referenced
this pull request
Mar 8, 2017
colesbury
referenced
this pull request
in colesbury/nogil
Oct 6, 2021
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
jaraco
pushed a commit
to jaraco/cpython
that referenced
this pull request
Feb 17, 2023
Backport bpo-33254 - contents() returns an Iterable Closes python#52 See merge request python-devs/importlib_resources!57
isidentical
pushed a commit
to isidentical/cpython
that referenced
this pull request
Mar 28, 2023
oraluben
pushed a commit
to oraluben/cpython
that referenced
this pull request
Jul 12, 2023
Co-authored-by: Ken Jin <[email protected]> Co-authored-by: Brandt Bucher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set name to "_curses.window" instead of "_curses.curses window" (with
a space!?).