Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32604: Improve subinterpreter tests. #6914

Merged
merged 18 commits into from
May 16, 2018
Merged

bpo-32604: Improve subinterpreter tests. #6914

merged 18 commits into from
May 16, 2018

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented May 16, 2018 •
edited by bedevere-bot
Loading

Add more tests for subinterpreters. This patch also fixes a few small defects in the channel implementation.

https://bugs.python.org/issue32604

@ericsnowcurrently
Convert channel IDs into channels when shared.
828a227
@ericsnowcurrently
Only convert channel IDs when requested.
bac0f12
@ericsnowcurrently
channel_drop_interpreter -> channel_release.
5242a34
@ericsnowcurrently
Organize tests.
7b2407d
@ericsnowcurrently
Fix function signatures.
6a5d1fc
@ericsnowcurrently
Add InterpreterID/ChannelID.__str__().
c34ff90
@ericsnowcurrently
Return an InterpreterID from get_main().
cbbc562
@ericsnowcurrently
Add support for int.
49e8065
@ericsnowcurrently
Correctly handle \x00 when sharing bytes.
cb41fa5
@ericsnowcurrently
Test channel_close() across a broad spectrum of cases.
13e6b7a
@ericsnowcurrently
Fix a typo.
2ee8cb0
@ericsnowcurrently
Add an exhaustive set of permutated tests for close_channel().
ecb5834
@ericsnowcurrently
Fix run_action() for close operations.
262e53e
@ericsnowcurrently
Skip the exhaustive tests.
7028808
@ericsnowcurrently
Add a note about lookup of cross-interpreter types.
5479620
@ericsnowcurrently
Add support for str.
13c51d4
@ericsnowcurrently
Move the normal channel_close() tests.
4cf75a2
@ericsnowcurrently
Do not mask errors in _channel_recv().
bffbbfc
@ericsnowcurrently ericsnowcurrently merged commit 6d2cd90 into python:master May 16, 2018
@bedevere-bot
Copy link

@ericsnowcurrently: Please replace # with GH- in the commit message next time. Thanks!

@ericsnowcurrently ericsnowcurrently deleted the interpreters-tests branch May 16, 2018 20:46
This was referenced May 30, 2018
Merged
Merged
ericsnowcurrently added a commit that referenced this pull request May 31, 2018
@ericsnowcurrently
bpo-33615: Temporarily disable a test that is triggering crashes on a…
110bc01 
… few buildbots. (gh-7288)

For bpo-32604 I added some subinterpreter-related tests (see #6914) that are causing crashes on a few buildbots. I'm working on fixing the crashes (see #7251).  This change temporarily disables the triggering test.
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jun 1, 2018
Merged
ericsnowcurrently added a commit that referenced this pull request Jun 2, 2018
@ericsnowcurrently
bpo-33615: Re-enable a subinterpreter test. (gh-7251)
6379913 
For bpo-32604 I added extra subinterpreter-related tests (see #6914), which caused a few buildbots to crash. This patch fixes the crash by ensuring that refcounts in channels are handled properly.
@ericsnowcurrently ericsnowcurrently mentioned this pull request Aug 24, 2018
Closed
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericsnowcurrently @bedevere-bot @the-knights-who-say-ni