bpo-19382: Adding test cases for module tabnanny. #851

ultimatecoder · 2017-03-27T17:19:39Z

Description: Unit tests for standard module tabnanny. Tests are added for almost all the functionality except tabnanny.Whitespace class.
Reason leaving Whitespace:? I found the module contains mathematical calculations. I will try to understand it first and then write tests for it. I think it will be good to do that in another branch.
Testing strategy: Whitebox
BPOs
- https://bugs.python.org/issue19382
- https://bugs.python.org/issue19102

https://bugs.python.org/issue19382

DimitrisJim · 2017-03-27T17:37:36Z

Hi @ultimatecoder, you'll also need to remove tabnanny from the untested tuple in test_sundry. This is one of the failures AppVeyor (and soon Travis, I'd guess), reports.

vadmium · 2017-03-27T21:00:22Z

Lib/test/test_tabnanny.py

+
+        Use this method to assert expected values of `stdout` and `stderr` after
+        running tabsize.check() on given `dir` or `file` path. Because
+        tabsize.check() captures arised exceptions and writes to `stdout` and


Just write “captures exceptions” (or change arised → raised).

What is “tabsize”? Did you mean “tabnanny.check”?

vadmium · 2017-03-27T21:00:24Z

Lib/test/test_tabnanny.py

+                                     Returns path of the created file. Returned
+                                     file path can be feeded to
+                                     `tabnanny.check()`.  Here, the expression
+                                     `*` at function name is dipicting the


feeded → fed
dipicting → depicting

vadmium · 2017-03-27T21:04:18Z

Lib/test/test_tabnanny.py

+            * dir_or_file : A path to file or directory. This argument will be
+                            feeded directly to tabnanny.check().
+            * out         : Expacted `stdout` after running tabsize.check().
+            * err         : Expacted `stderr` after running tabsize.check().


feeded → fed
Expacted → Expected

vadmium · 2017-03-27T21:10:42Z

Lib/test/test_tabnanny.py

+        """Directory containing few error free python source code files.
+
+        Because order of files returned by `os.lsdir()` is not fixed, verifying
+        existance of each output lines at `stdout` using `in` operator.


verifying → verify the
existance → existence

vadmium · 2017-03-27T21:12:58Z

Lib/test/test_tabnanny.py

+        self._verify_tabnanny_check(file_path)
+
+    def test_correct_directory_verbose(self):
+        """Directory containing few error free python source code files.


few → a few [otherwise, the implication is that most of the files have errors: few are error-free]

vadmium · 2017-03-27T21:53:51Z

Lib/test/test_tabnanny.py

+    """Testing `tabnanny.format_witnesses()`."""
+
+    def test_format_whitenesses(self):
+        """Asserting formatter result by givinig various input samples."""


vadmium · 2017-03-27T21:58:56Z

Lib/test/test_tabnanny.py

+        self._validate_cmd(stderr=stderr)
+
+    def test_quiet_flag(self):
+        """Should not display less when quite mode is on."""


quiet mode?
“less” looks wrong, unless you meant “Should display less”

vadmium · 2017-03-27T21:59:17Z

Lib/test/test_tabnanny.py

+    def test_quiet_flag(self):
+        """Should not display less when quite mode is on."""
+        file_path = create_python_file(SOURCE_CODES["nannynag_errored"])
+        stdout = b"%s\n" % (file_path.encode('ascii'),)


Don’t you get CRLF on Windows?

vadmium · 2017-03-27T22:09:11Z

Lib/test/test_tabnanny.py

+    def test_with_errored_file(self):
+        """Should displays error when errored python file is given."""
+        file_path = create_python_file(SOURCE_CODES["wrong_indented"])
+        stderr = b"%r: Indentation Error: " % (file_path,)


In Python 3, b"%r" is equivalent to calling the “ascii” function. I expect the test will fail if the file path has non-ASCII characters. It may be better to only test that an error is being reported, but tolerate variations in the message.

vadmium · 2017-03-27T22:12:10Z

Lib/test/test_tabnanny.py

+    def test_command_usage(self):
+        """Should display usage on no arguments."""
+        path = findfile('tabnanny.py')
+        stderr = b'Usage: %s [-v] file_or_directory ...' % (path.encode('ascii'))


What if the path is non-ASCII? Again, just check the general form of the output and don’t be too specific.

I don't think this https://github.com/python/cpython/blob/master/Lib/tempfile.py#L144 generates anything Non-ASCII.

No, but the OS can provide a parent directory for temporary files that has non-ASCII path components. It seems relatively common on Windows that the temporary directory is within a user’s profile, and the profile directory can be a localized non-ASCII name. Top Google result: https://bugzilla.mozilla.org/show_bug.cgi?id=260034.

Many thanks for affording time for reviewing this. I will agree with you on this point. I have updated code. Will you please review again?

vadmium · 2017-03-27T22:16:33Z

Check out the existing patches and reviews you linked. You may be repeating some of the same problems, e.g. CRLF on Windows.

ultimatecoder · 2017-03-28T07:54:41Z

@vadmium Many thanks for your comments. I am not native English speaker. I have fixed the mistakes. I have added comments to some comments. Please review my fixes. Thanks!

@DimitrisJim Thanks for your comment. I have removed tabnanny from untested modules list. Thanks!

vadmium · 2017-04-09T00:55:02Z

Sorry but I don’t have an easy way to see your fixes relative to the old version I reviewed. I’m not really set up to properly review and push stuff with the new Git Hub setup, so I will leave this to someone else, or for another time in the future.

vstinner · 2017-05-04T13:02:10Z

Lib/test/test_tabnanny.py

@@ -0,0 +1,348 @@
+"""Testing `tabnanny` module.
+


remove one empty line

Removed this. This is Github glitch.

vstinner · 2017-05-04T13:02:32Z

Lib/test/test_tabnanny.py

+    * errored    : Whitespace related problems present in file.
+"""
+from unittest import TestCase, mock
+from unittest.mock import patch


Hum, I prefer to write mock.patch, please remove this import

vstinner · 2017-05-04T13:02:58Z

Lib/test/test_tabnanny.py

+from unittest.mock import patch
+import tabnanny
+import tokenize
+from tempfile import NamedTemporaryFile, TemporaryDirectory


Please import tempfile and write tempfile.NamedTemporaryFile.

vstinner · 2017-05-04T13:03:35Z

Lib/test/test_tabnanny.py

+
+    It creates file with `.py` extension.
+
+    Returns: Absolute path of created code file."""


IMHO this docstring is useless. Usually, we don't comment much tests, they are not intented to end users.

vstinner · 2017-05-04T13:04:36Z

Lib/test/test_tabnanny.py

+
+    Returns: Absolute path of created code file."""
+    with NamedTemporaryFile(mode='w', dir=dir,
+                            delete=False, suffix=".py") as f:


If you only care of creating a temporary filename, use tempfile.mktemp() and then open() manually the file to create it. You can use open(tmpname, "x") to prevent race conditions.

vstinner · 2017-05-04T13:06:01Z

Lib/test/test_tabnanny.py

+    def test_errprint(self):
+        """Asserting result of `tabnanny.errprint()` by giving sample inputs."""
+        tests = [
+            {'args': ['first', 'second'], 'expected': 'first second\n'},


Instead of a dict, you can simply use a tuple (args, expected)

Don't think we should kill the readability by converting it to tuple. How about collections.namedtuple?

Or How about this way?

tests = [ # (Function arguments , Expected output) (['first', 'second'], 'first second\n'), (['first'] , 'first\n'), ([1, 2, 3] , '1 2 3\n'), ([] , '\n') ]

Keep tests simple:

for args, expected in [ ([1], '1'), ]:

Yes, keep them simple. And don't use namedtuples except for keeping backwards-compatibility with an interface that used to take an indexed object and now takes an object with attributes.

vstinner · 2017-05-04T13:07:22Z

Lib/test/test_tabnanny.py

+
+
+class TestNannyNag(TestCase):
+    """Testing `tabnanny.NannyNag` exception."""


Not sure that this docstring is super useful.

vstinner · 2017-05-04T13:08:59Z

Lib/test/test_tabnanny.py

+            self.assertEqual(stderr.getvalue() , test['expected'])
+
+
+class TestNannyNag(TestCase):


I don't think that it's worth it to declare one test case to test a single class/function. Try to put most or all tests into a single test case called "TabnannyTestCase".

TestCheck deserves its own test case since it has a setUp() method.

vstinner · 2017-05-04T13:09:32Z

Lib/test/test_tabnanny.py

+class TestNannyNag(TestCase):
+    """Testing `tabnanny.NannyNag` exception."""
+    def setUp(self):
+        self.tests = [


Please move this list into the method directly.

vstinner · 2017-05-04T13:11:10Z

Lib/test/test_tabnanny.py

+    """Testing tabnanny.check()."""
+
+    def setUp(self):
+        tabnanny.verbose = 0  # Forcefully deactivating verbose mode.


Unit tests must have zero side effect: you must save the old verbose value and restore it. Example:

self.addCleanup(setattr, tabnanny, 'verbose', tabnanny.verbose) tabnanny.verbose = 0

Aha! a geek way 👍

vstinner · 2017-05-04T13:11:33Z

Lib/test/test_tabnanny.py

+    def setUp(self):
+        tabnanny.verbose = 0  # Forcefully deactivating verbose mode.
+
+    def _verify_tabnanny_check(self, dir_or_file, out="", err=""):


No need to make this method private, remove "_" prefix.

vstinner · 2017-05-04T13:11:56Z

Lib/test/test_tabnanny.py

+            * dir_or_file : A path to file or directory. This argument will be
+                            fed directly to tabnanny.check().
+            * out         : Expected `stdout` after running tabnanny.check().
+            * err         : Expected `stderr` after running tabnanny.check().


Again, I'm not sure that a long comment is needed for a simple unit test.

I think it is explaining why the method is here. Suggest a way for improving the docstring.

At least ditch the whole Arguments section; we don't use that style in the stdlib.

vstinner · 2017-05-04T13:12:47Z

Lib/test/test_tabnanny.py

+
+    def test_correct_file(self):
+        """A python source code file without any errors."""
+        file_path = create_tmp_python_file(SOURCE_CODES["error_free"])


Who removes the temporary file? I suggest to put create_tmp_python_file() in the test case (or in a base class if it's needed by multiple test cases) and use self.addCleanup(support.unlink, tmpfile) to make sure that the temporary file is removed.

Adding it to a method will be a poor idea. If I will add it to base class then we will have a base class with one method. Will you accept that?

Yes, if the method needs to access information that will be on the instance then a class with a single method is fine. But if you aren't reusing it then just inline the function.

vstinner

I like the overall change, but I have a long list of requests :-)

vstinner · 2017-05-04T13:15:23Z

Lib/test/test_tabnanny.py

+
+    @patch('tabnanny.NannyNag')
+    def test_with_correct_code(self, MockNannyNag):
+        """A python source code without any whitespace related problems."""


IMHO the docstring is useless.

vstinner · 2017-05-04T13:16:08Z

Lib/test/test_tabnanny.py

+            exception = tabnanny.NannyNag
+            with open(file_path) as f:
+                tokens = tokenize.generate_tokens(f.readline)
+                self.assertRaises(exception, tabnanny.process_tokens, tokens)


Move this assert out of the with block.

We can't move this out.

Why not? Is tokenize.generate_tokens() lazy (which isn't documented)?

@brettcannon The tokenize.generate_tokens() is a lazy function (generator). Can you help to identify a way which allows putting assertRaises outside the with? Thanks!

vstinner · 2017-05-04T13:17:09Z

Lib/test/test_tabnanny.py

+        """
+        rc, out, err = script_helper.assert_python_ok('-m', 'tabnanny', *args)
+        # Note: The `splitlines()` will solve the problem of CRLF(\r) added
+        # by OS Windows.


Use universal_newlines=True to normalize newlines. I also prefer to use text rather than bytes for stdout/stderr.

I don't think these chain of methods, assert_python_ok -> _assert_python -> run_python_until_end is allowing to pass universal_newlines keyword argument!

Reference: https://github.com/python/cpython/blob/master/Lib/test/support/script_helper.py#L94

Are you suggesting to replace script_helper.assert_python_ok() with subprocess.Popen() here?

vstinner · 2017-05-04T13:17:43Z

Lib/test/test_tabnanny.py

+        # Note: The `splitlines()` will solve the problem of CRLF(\r) added
+        # by OS Windows.
+        self.assertListEqual(out.splitlines(), stdout.splitlines())
+        self.assertEqual(rc, return_code)


assert_python_ok() already tests that returncode==0.

vstinner · 2017-05-04T13:18:34Z

Lib/test/test_tabnanny.py

+class TestCommandLine(TestCase):
+    """Tests command line interface of `tabnanny`."""
+
+    def _validate_cmd(self, *args, return_code=0, stdout=b"", stderr=b""):


make this method public

vstinner · 2017-05-04T13:19:37Z

Lib/test/test_tabnanny.py

+    def test_double_verbose_mode(self):
+        """Should display detailed error information if double verbose is on."""
+        file_path = create_tmp_python_file(SOURCE_CODES["nannynag_errored"])
+        stdout = b"checking %r ...\n" % (file_path,)


For better readability, you can use textwrap.dedent() and a multiline """...""" indented string. See test_faulthandler for examples.

This is a nice suggestion 👍 Are you expecting these multiline strings to convert into a regular expression? I think this way just looks fine.

JelleZijlstra · 2017-05-05T04:56:43Z

Lib/test/test_tabnanny.py

+class TestFormatWitnesses(TestCase):
+    """Testing `tabnanny.format_witnesses()`."""
+
+    def test_format_whitenesses(self):


witnesses, not whitenesses

brettcannon · 2018-02-21T01:51:39Z

To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request.

If/when the requested changes have been made, please leave a comment that says, I have made the requested changes; please review again. That will trigger a bot to flag this pull request as ready for a follow-up review.

ultimatecoder · 2018-02-21T04:51:21Z

@brettcannon Many thanks for your comment. I had tried to comment back at confusing points. I think @vstinner lost his interest in my solution. What efforts should I do to make it mergeable? Have a great day!

brettcannon · 2018-02-21T18:57:16Z

@ultimatecoder if you think you have addressed all of the comments left by @vstinner then just leave a comment that says I have made the requested changes; please review again.

ultimatecoder · 2018-02-22T06:30:44Z

@brettcannon I have done the requested changes. There were few which I would like to discuss with @vstinner according to his availability. He has pointed out few changes on which I am confused about. I have tried to write back as a part of reply comment in response to improvement comment. I hope I made a clear statement about the situation. Thanks!

ultimatecoder · 2018-03-01T06:42:32Z

@brettcannon Many thanks for your comments. I am under little work pressure. Please expect answers/improvements at the end of this week. Thanks!

ultimatecoder · 2018-05-15T06:22:42Z

@brettcannon Reminding you for this PR. All the best for sprints 👍

brettcannon · 2018-05-15T15:31:37Z

@ultimatecoder no need as this is the top of the list for when I actually get time to start reviewing PRs 😉

brettcannon

Nothing fundamentally wrong, just some things to help make the tests easier to manage in future years.

brettcannon · 2018-05-15T18:49:23Z

Lib/test/test_tabnanny.py

+            ([]                 , '\n')
+        ]
+
+        for args, expected in tests:


I would use subtests here: https://docs.python.org/3/library/unittest.html#distinguishing-test-iterations-using-subtests

brettcannon · 2018-05-15T18:50:52Z

Lib/test/test_tabnanny.py

+        `verbose` mode of `tabnanny.verbose` asserts `stdout`.
+        """
+        with tempfile.TemporaryDirectory() as tmp_dir:
+            lines = ["%r: listing directory\n" % (tmp_dir,),]


Use f-strings everywhere. 😄

brettcannon · 2018-05-15T18:51:51Z

Lib/test/test_tabnanny.py

+        """
+        with tempfile.TemporaryDirectory() as tmp_dir:
+            lines = ["%r: listing directory\n" % (tmp_dir,),]
+            with TemporaryPyFile(


To make this easier to read, I would create the context managers outside the with statement:

file1 = TemporaryPyFile(...) file2 = TemporaryPyFile(...) with file1 as file1_path, file2 as file2_path: ...

For this specific case, IMHO "file1 = ..." is better.

brettcannon · 2018-05-15T18:52:54Z

Lib/test/test_tabnanny.py

+    def test_correct_directory(self):
+        """Directory which contains few error free python source code files."""
+        with tempfile.TemporaryDirectory() as tmp_dir:
+            with TemporaryPyFile(


Move the TemporaryPyFile instantiation to its own line so you don't have to spread over multiple lines. (Same of the other lines where you were forced to spread a with statement over multiple lines.)

I looked at the new code and it's fine.

brettcannon · 2018-05-15T18:58:34Z

Lib/test/test_tabnanny.py

+
+    def test_when_tokenize_tokenerror(self):
+        """A python source code file eligible for raising 'tokenize.TokenError'.
+        """


Pull this up to the next line up (it's okay for it to spill over 80 columns).

brettcannon · 2018-05-15T19:00:08Z

Lib/test/test_tabnanny.py

+            SOURCE_CODES["nannynag_errored"]
+        ) as file_path:
+            out = "%r: *** Line 3: trouble in tab city! ***\n" % (file_path,)
+            out += "offending line: '\\tprint(\"world\")\\n'\n"


Don't worry too much about the exact output being formatted as it is. For instance, if someone tweaked the grammar of the sentence the test should still pass. Do still check for semantically important info, though, like that the offending line is in the output.

Maybe the test is too strict, but IMHO we have been too pendantic on this nice PR which has been proposed 3 months ago. tabnanny has currently no test. If the test fails tomorrow, we will just fix the test. No need to write the perfect test here.

brettcannon · 2018-05-15T19:04:07Z

Lib/test/test_tabnanny.py

+    def test_when_no_file(self):
+        """A python file which does not exist actually in system."""
+        file_path = 'no_file.py'
+        err = "%r: I/O Error: [Errno 2] No such file or directory: %r\n" % (


You don't want to tie yourself to exception messages as they do change between versions. Just care about the right exception being raised.

I agree, but the code does not raise an exception reference: https://github.com/python/cpython/blob/master/Lib/tabnanny.py#L99
What way will be better to assert the working of mentioned function?

brettcannon · 2018-05-15T19:08:28Z

Lib/test/test_tabnanny.py

+        #                        `check_equal and type not in JUNK` condition at
+        #                        `tabnanny.process_tokens()`.
+
+        for key in ["tab_space_errored_1", "tab_space_errored_2"]:


Sub tests would be great here.

bedevere-bot · 2018-05-15T19:09:34Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ultimatecoder · 2018-05-16T12:18:39Z

@brettcannon I am a bit busy with present work. I am sure, I will not be able to complete during this sprints. But I will be able to improve according to your comments in few days. Thanks for reviewing :)

brettcannon · 2018-05-16T16:25:21Z

@ultimatecoder no rush! I'm not expecting to take quite so long to do future reviews as I only need to review relative future changes.

vstinner

Please remove Lib/test/.test_tabnanny.py.swo from your PR.

vstinner

Oh, I am sorry, I forgot about your old PR :-( Here is a new review. Your PR is very close to be ready to be merged. Sorry again about the slow review :-(

vstinner · 2018-06-10T11:36:14Z

Lib/test/test_tabnanny.py

+        """Asserting formatter result by giving various input samples."""
+        tests = [
+            ('Test' , 'at tab sizes T, e, s, t'),
+            (''     , 'at tab size '),


Sorry but this style is not compliant with PEP 8, please strip spaces before ",".

vstinner · 2018-06-10T11:37:16Z

Lib/test/test_tabnanny.py

+
+    def __exit__(self, exc_type, exc_value, exc_traceback):
+        if exc_type is None:
+            unlink(self.file_path)


You should always remove the created file.

vstinner · 2018-06-10T11:42:03Z

Lib/test/test_tabnanny.py

+
+    def validate_cmd(self, *args, stdout="", stderr=""):
+        """Common function to assert the behaviour of command line interface."""
+        _, out, err = script_helper.assert_python_ok('-m', 'tabnanny', *args)


You may use:

proc = script_helper.spawn_python('-m', 'tabnanny', *args, text=True)
out, err = proc.communicate()
self.assertEqual(out, stdout)
self.assertEqual(err, stderr)
self.assertEqual(proc.returncode, 0)

text=True normalizes newlines to \n (Unix EOL).

ultimatecoder · 2018-06-10T11:47:34Z

@vstinner Thanks for re-observing this. I am working on the improvements suggested by you and @brettcannon 😃

ultimatecoder · 2018-06-10T11:53:29Z

@brettcannon I have updated the changes according to your comments. There is one comment in which you mentioned to assert the exception and not the output. I have added a reply to that comment with a reference. I request to provide your input on that. Thanks.

ultimatecoder · 2018-06-10T12:25:06Z

@vstinner I have improved the code according to your suggestion. I request to re-review.

vstinner · 2018-06-11T11:41:55Z

Lib/test/test_tabnanny.py

+
+    def __exit__(self, exc_type, exc_value, exc_traceback):
+        unlink(self.file_path)
+        return exc_type is None


I'm not sure that returning True is correct here. I just suggest to remove the "return" line.

I agree, returning True isn't making sense here. Thanks for commenting.

Whitebox.

ultimatecoder · 2018-06-14T04:38:24Z

@vstinner @brettcannon I have updated the code according to your comments. I request to proceed for further review. Thanks.

I checked all latest Brett's comments: all fixed

ultimatecoder · 2018-06-14T07:53:32Z

@vstinner Thanks for taking time and reviewing this PR.

@vstinner Thank you for reviewing your PR and inspiring for continuing.

I have learned many this at the time of creating, maintaining this Patch.

the-knights-who-say-ni added the CLA signed label Mar 27, 2017

brettcannon added the tests Tests in the Lib/test dir label Mar 27, 2017

vadmium reviewed Mar 27, 2017

View reviewed changes

ultimatecoder force-pushed the master-add-test-tabnanny-module branch from d66ae89 to f9b9e5c Compare March 28, 2017 07:04

ultimatecoder force-pushed the master-add-test-tabnanny-module branch from f9b9e5c to d9953b9 Compare April 6, 2017 05:46

vstinner reviewed May 4, 2017

View reviewed changes

vstinner requested changes May 4, 2017

View reviewed changes

JelleZijlstra reviewed May 5, 2017

View reviewed changes

brettcannon added the awaiting changes label Feb 21, 2018

brettcannon previously requested changes May 15, 2018

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting change review labels May 15, 2018

ultimatecoder force-pushed the master-add-test-tabnanny-module branch from dcf42e5 to ebff66b Compare June 10, 2018 04:32

vstinner reviewed Jun 10, 2018

View reviewed changes

ultimatecoder force-pushed the master-add-test-tabnanny-module branch from db139c5 to 83083c9 Compare June 10, 2018 11:44

ultimatecoder force-pushed the master-add-test-tabnanny-module branch 2 times, most recently from a2be776 to e9f48d6 Compare June 10, 2018 12:22

vstinner reviewed Jun 11, 2018

View reviewed changes

[ADD] Adding test cases for module tabnanny. Testing stratergy:

86b9ad2

Whitebox.

ultimatecoder force-pushed the master-add-test-tabnanny-module branch from e9f48d6 to 86b9ad2 Compare June 14, 2018 04:25

vstinner added the skip news label Jun 14, 2018

vstinner approved these changes Jun 14, 2018

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting changes labels Jun 14, 2018

vstinner merged commit dfa9643 into python:master Jun 14, 2018

bedevere-bot removed the awaiting merge label Jun 14, 2018


		It creates file with `.py` extension.

		Returns: Absolute path of created code file."""



		class TestNannyNag(TestCase):
		"""Testing `tabnanny.NannyNag` exception."""

		self.assertEqual(stderr.getvalue() , test['expected'])


		class TestNannyNag(TestCase):

bpo-19382: Adding test cases for module tabnanny. #851

bpo-19382: Adding test cases for module tabnanny. #851

Conversation

ultimatecoder commented Mar 27, 2017 • edited by bedevere-bot Loading

DimitrisJim commented Mar 27, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vadmium commented Mar 27, 2017

ultimatecoder commented Mar 28, 2017

vadmium commented Apr 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vstinner May 4, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vstinner May 4, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vstinner May 4, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vstinner left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brettcannon Feb 22, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brettcannon commented Feb 21, 2018

ultimatecoder commented Feb 21, 2018

brettcannon commented Feb 21, 2018

ultimatecoder commented Feb 22, 2018

ultimatecoder commented Mar 1, 2018

ultimatecoder commented May 15, 2018

brettcannon commented May 15, 2018

brettcannon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ultimatecoder commented Mar 27, 2017 •

edited by bedevere-bot

Loading

DimitrisJim commented Mar 27, 2017 •

edited

Loading

vstinner May 4, 2017 •

edited

Loading

vstinner May 4, 2017 •

edited

Loading

vstinner May 4, 2017 •

edited

Loading

brettcannon Feb 22, 2018 •

edited

Loading