-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-19569: Add a macro to suppress deprecation warnings (counterpart of Py_DEPRECATED()) #9004
bpo-19569: Add a macro to suppress deprecation warnings (counterpart of Py_DEPRECATED()) #9004
Conversation
…of Py_DEPRECATED()) Co-Authored-By: Arfrever Frehtes Taifersar Arahesis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should explain more clearly why this is needed.
These macros can be used to locally suppress deprecation warnings if a deprecated C API function needs to be used. There was some relevant discussion on the BPO issue. |
Could you give a more concrete pointers? I didn't find the justification for this PR. |
When I uncomment |
It seems these macros are too much. |
@ZackerySpytz Would you make these macros private? (e.g. adding _ prefix). |
Thanks @ZackerySpytz for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
GH-20907 is a backport of this pull request to the 3.9 branch. |
Co-authored-by: Arfrever Frehtes Taifersar Arahesis <[email protected]> (cherry picked from commit de4304d) Co-authored-by: Zackery Spytz <[email protected]>
Co-authored-by: Arfrever Frehtes Taifersar Arahesis <[email protected]> (cherry picked from commit de4304d) Co-authored-by: Zackery Spytz <[email protected]>
Co-authored-by: Arfrever Frehtes Taifersar Arahesis <[email protected]>
Co-Authored-By: Arfrever Frehtes Taifersar Arahesis [email protected]
https://bugs.python.org/issue19569