gh-94192: Fix error for dictionary literals with invalid expression as value. #94304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should've run patchcheck 😅 |
pablogsal
approved these changes
Jun 26, 2022
|
Thanks a lot for the PR @wookie184 |
pablogsal
added
awaiting review
needs backport to 3.11
|
Thanks @wookie184 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 26, 2022
…sion as value. (pythonGH-94304) * Fix error for dictionary literals with invalid expression as value. * Remove trailing whitespace (cherry picked from commit 8c237a7) Co-authored-by: wookie184 <[email protected]>
|
Sorry, @wookie184 and @pablogsal, I could not cleanly backport this to |
|
GH-94308 is a backport of this pull request to the 3.11 branch. |
|
@wookie184 Can you do the backport to 3.10 using cherry-picker? |
miss-islington
added a commit
that referenced
this pull request
Jun 26, 2022
…s value. (GH-94304) * Fix error for dictionary literals with invalid expression as value. * Remove trailing whitespace (cherry picked from commit 8c237a7) Co-authored-by: wookie184 <[email protected]>
wookie184
added a commit
to wookie184/cpython
that referenced
this pull request
Jun 27, 2022
… expression as value. (pythonGH-94304) * Fix error for dictionary literals with invalid expression as value. * Remove trailing whitespace. (cherry picked from commit 8c237a7) Co-authored-by: wookie184 <[email protected]>
|
GH-94344 is a backport of this pull request to the 3.10 branch. |
pablogsal
pushed a commit
that referenced
this pull request
Jun 27, 2022
…ssion as value. (GH-94304) (#94344) Co-authored-by: wookie184 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #94192
I just added
&('}'|',')which is the same as what was already done on line 1312. I couldn't think of any cases this makes worse and the existing tests seemed to run the same so I think this should be fine.