Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.10] gh-82006: IDLE doc improvements (GH-94349) #94358

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 27, 2022

  1. Update text start and stop conditions.
  2. Title-case sections but not subsections.
  3. Edit Shell Window sections: title, execute, restart.
    (cherry picked from commit e6391e0)

Co-authored-by: Terry Jan Reedy [email protected]

0. Update text start and stop conditions.
1. Title-case sections but not subsections.
2. Edit Shell Window sections: title, execute, restart.
(cherry picked from commit e6391e0)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@terryjreedy: Status check is done, and it's a success ❌ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@terryjreedy: Status check is done, and it's a success ❌ .

@terryjreedy
Copy link
Member

@ezio-melotti @JulienPalard The Docs/Docs test failed with

Warning, treated as error:
[library/idle:597] "`" found in "Lines containing`’RESTART’` mean that the user execution process has been"
make[1]: *** [Makefile:51: build] Error 2
make: *** [Makefile:115: suspicious] Error 1
make[1]: Leaving directory '/home/runner/work/cpython/cpython/Doc'
Suspicious check complete; look for any errors in the above output or in build/suspicious/suspicious.csv.  If all issues are false positives, append that file to tools/susp-ignored.csv.
make: Leaving directory '/home/runner/work/cpython/cpython/Doc'
Error: Process completed with exit code 2.

(I noticed the missing ' '.) This same test passed for main and 3.11, and for main, the resulting .html looks OK.
Why fail here?

Since this is not required, I could commit anyway. Any problem? Or ask someone else?

@terryjreedy terryjreedy reopened this Jun 28, 2022
@miss-islington
Copy link
Contributor Author

@terryjreedy: Status check is done, and it's a success ❌ .

4 similar comments
@miss-islington
Copy link
Contributor Author

@terryjreedy: Status check is done, and it's a success ❌ .

@miss-islington
Copy link
Contributor Author

@terryjreedy: Status check is done, and it's a success ❌ .

@miss-islington
Copy link
Contributor Author

@terryjreedy: Status check is done, and it's a success ❌ .

@miss-islington
Copy link
Contributor Author

@terryjreedy: Status check is done, and it's a success ❌ .

@ambv ambv merged commit eb7d354 into python:3.10 Jun 28, 2022
@miss-islington miss-islington deleted the backport-e6391e0-3.10 branch June 28, 2022 10:51
@terryjreedy
Copy link
Member

@JulienPalard @ambv Thank you both for the fixes which result in all 3 versions looking the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants