Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-94512: Fix forced arg format in AC-processed msvcrtmodule #94514

Merged
merged 4 commits into from
Jul 4, 2022
Merged

gh-94512: Fix forced arg format in AC-processed msvcrtmodule #94514

merged 4 commits into from
Jul 4, 2022

Conversation

arhadthedev
Copy link
Member

@arhadthedev arhadthedev commented Jul 2, 2022 •
edited by bedevere-bot
Loading

@arhadthedev arhadthedev requested a review from a team as a code owner July 2, 2022 19:41
@arhadthedev arhadthedev mentioned this pull request Jul 2, 2022
Open
7 tasks
@zooba zooba added the skip news label Jul 4, 2022
zooba
zooba reviewed Jul 4, 2022
View reviewed changes
Misc/NEWS.d/next/Library/2022-07-03-23-06-09.gh-issue-94512.W-g4ff.rst Outdated
@@ -0,0 +1 @@
Convert :mod:`msvcrt` to use Argument Clinic.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove - we don't need NEWS for this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@arhadthedev
Revert "Add a NEWS entry"
2321a3d 
This reverts commit 450875a.
@zooba zooba merged commit 21f6b4d into python:main Jul 4, 2022
@arhadthedev arhadthedev deleted the clinic-msvcrtmodule-deformat branch July 4, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba left review comments

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arhadthedev @zooba @bedevere-bot