-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-93896: always set event loop in asyncio.run and IsolatedAsyncioTestCase #94593
Conversation
kumaraditya303
commented
Jul 6, 2022
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: IsolatedAsyncioTestCase and asyncio.run no-longer call asyncio.set_event_loop #93896
f59b6eb
to
bd1eeb9
Compare
bd1eeb9
to
9576a91
Compare
Can you copy over the test cases from my PR? |
I added a test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix!
Thanks for the reviews! |
I think the docs should describe this change:
|
This would complicate things for an average user about how policy registry works. The existing docs is clear |
Thanks @kumaraditya303 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
GH-94608 is a backport of this pull request to the 3.11 branch. |
…ncioTestCase (pythonGH-94593) (cherry picked from commit 14fea6b) Co-authored-by: Kumar Aditya <[email protected]>
…stCase (GH-94593) (cherry picked from commit 14fea6b) Co-authored-by: Kumar Aditya <[email protected]>