gh-94906: Support multiple steps in math.nextafter #94908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hauntsaninja
commented
Jul 16, 2022
•
hauntsaninja
commented
- Issue: Let math.nextafter() compute multiple steps at a time. #94906
| @@ -3802,7 +3805,14 @@ math_nextafter_impl(PyObject *module, double x, double y) | |||
| return PyFloat_FromDouble(y); | |||
| } | |||
| #endif | |||
| return PyFloat_FromDouble(nextafter(x, y)); | |||
| if (steps < 1) { | |||
There was a problem hiding this comment.
You can allow zero steps just fine.
| PyErr_SetString(PyExc_ValueError, "steps must be >= 1"); | ||
| return NULL; | ||
| } | ||
| for (i = 0; i < steps; i++) { |
There was a problem hiding this comment.
You can support this without a loop. See this pure Python prototype for how that can work.
|
Closing since Matthias' no loop suggestion is appealing, there isn't much movement on the issue and I have a merge conflict :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.