WIP: bpo-22490: Remove __PYVENV_LAUNCHER__ from the codebase. #9498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a Mac and am motivated to help eradicating this thing (since it just wasted a bunch of my time already), but I'm rusty on how to test this thoroughly. Should I just configure --with-framework (or however it's spelled)? What tools would depend on this env var existing? |
|
I also am unsure about how to test, and it sounds like from Ronald says in the ticket that the approach presented here is misguided, although maybe only in the fact that it breaks OS X 10.6, which is 9 years old. So it may be that it's not possible to test without a very old mac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting this preliminary change to see how the CI builders react to the change.
https://bugs.python.org/issue22490