[3.11] gh-95041: Fix several minor issues in syslog.openlog() (GH-95058) #95261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…H-95058) * syslog_get_argv() swallows exceptions, but not in all cases. * if ident is non UTF-8 encodable, syslog.openlog() fails after setting the global reference to ident. Now the C string saved internally in the previous call to openlog() points to the freed memory. * PySys_Audit() can crash if ident is NULL. * There may be a race condition with syslog.syslog(), because the global reference to ident is decrefed before setting the new value. * Possible use of freed memory if syslog.openlog() is called while the GIL is released in syslog.syslog(). (cherry picked from commit 68c555a) Co-authored-by: Serhiy Storchaka <[email protected]>
bedevere-bot
added
skip news
type-bug
|
Status check is done, and it's a success ✅ . |
2 similar comments
|
Status check is done, and it's a success ✅ . |
|
Status check is done, and it's a success ✅ . |
serhiy-storchaka
approved these changes
Jul 26, 2022
|
Sorry, I can't merge this PR. Reason: |
|
Status check is done, and it's a success ✅ . |
|
Sorry, I can't merge this PR. Reason: |
|
Status check is done, and it's a success ✅ . |
|
Sorry, I can't merge this PR. Reason: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
global reference to ident. Now the C string saved internally in the previous
call to openlog() points to the freed memory.
reference to ident is decrefed before setting the new value.
the GIL is released in syslog.syslog().
(cherry picked from commit 68c555a)
Co-authored-by: Serhiy Storchaka [email protected]