gh-95273: Condense sqlite3 executescript example #95383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
erlend-aasland
commented
Jul 28, 2022
•
erlend-aasland
commented
- Issue: Improve the sqlite3 reference #95273
erlend-aasland
added
needs backport to 3.10
5 tasks
|
Also, the current example is faulty bco. lack of transaction handling: there is no commit; the connection is closed with a pending transaction. |
erlend-aasland
commented
Jul 28, 2022
CAM-Gerlach
reviewed
Jul 29, 2022
|
Thanks for the review, CAM! |
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
erlend-aasland
deleted the
sqlite-reference/condense-executescript-example
branch
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 29, 2022
(cherry picked from commit e9c8de6) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
|
GH-95418 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 29, 2022
(cherry picked from commit e9c8de6) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
|
GH-95419 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Jul 29, 2022
(cherry picked from commit e9c8de6) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
erlend-aasland
pushed a commit
that referenced
this pull request
Jul 29, 2022
(cherry picked from commit e9c8de6) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.