-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-87092: compiler's codegen stage uses int jump target labels, and the target pointer is only calculated just before optimization stage #95655
Conversation
iritkatriel
commented
Aug 4, 2022
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: Split compiler into code-gen, optimizer and assembler. #87092
Skipping news because this continues the work described in the news entry on #95398. |
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit cdde94f 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit bb16973 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 8a57c23 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
The FreeBsd timeout seems unrelated - it's doing that on other PRs. This is ready to be reviewed now. With this I can write the unit tests without needing the test harness to worry about blocks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion, otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍