Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-96168: Improve sqlite3 dict_factory example #96457

Merged
merged 3 commits into from
Sep 1, 2022
Merged

gh-96168: Improve sqlite3 dict_factory example #96457

merged 3 commits into from
Sep 1, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 31, 2022 •
edited by bedevere-bot
Loading

  • use dict comprehension
  • use doctest iso. testcode, for visualising the
    effect of the row factory
  • SELECT with multiple columns, so the effect of
    the row factory becomes clearer

@erlend-aasland
pythongh-96168: Improve sqlite3 dict_factory example
430bb2a 
- use dict comprehension
- use doctest iso. testcode, for visualising the
  effect of the row factory
- SELECT with multiple columns, so the effect of
  the row factory becomes clearer
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.10 only security fixes labels Aug 31, 2022
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Aug 31, 2022
ezio-melotti
ezio-melotti reviewed Aug 31, 2022
View reviewed changes
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
ezio-melotti
ezio-melotti approved these changes Aug 31, 2022
View reviewed changes
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
CAM-Gerlach
CAM-Gerlach reviewed Sep 1, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor comments, otherwise LGTM 👍 It looks a lot clearer to me than before, as well as more testable, concise and following more modern coding practices.

Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Show resolved Hide resolved
@CAM-Gerlach
Address review: fix SQL style
c4c9656 
Co-authored-by: C.A.M. Gerlach <[email protected]>
@erlend-aasland
Copy link
Contributor Author

Thanks for the reviews, CAM & Ezio!

@erlend-aasland erlend-aasland merged commit 91f40f3 into python:main Sep 1, 2022
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the sqlite-docs-dict-factory branch September 1, 2022 21:48
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 1, 2022
@bedevere-bot
Copy link

GH-96494 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 1, 2022
@miss-islington
pythongh-96168: Improve sqlite3 dict_factory example (pythonGH-96457)
cdb3bd1 
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>
(cherry picked from commit 91f40f3)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot
Copy link

GH-96495 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 1, 2022
@miss-islington
pythongh-96168: Improve sqlite3 dict_factory example (pythonGH-96457)
1dfce7a 
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>
(cherry picked from commit 91f40f3)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 1, 2022
miss-islington added a commit that referenced this pull request Sep 1, 2022
@miss-islington
gh-96168: Improve sqlite3 dict_factory example (GH-96457)
fca8e94 
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>
(cherry picked from commit 91f40f3)

Co-authored-by: Erlend E. Aasland <[email protected]>
miss-islington added a commit that referenced this pull request Sep 1, 2022
@miss-islington
gh-96168: Improve sqlite3 dict_factory example (GH-96457)
bbcb03e 
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>
(cherry picked from commit 91f40f3)

Co-authored-by: Erlend E. Aasland <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments

@ezio-melotti ezio-melotti ezio-melotti approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @miss-islington @bedevere-bot @CAM-Gerlach @ezio-melotti