Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-96810: Clarify when sqlite3 implicitly opens transactions #96832

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Sep 14, 2022

@erlend-aasland
Copy link
Contributor Author

cc. @KennyChenBasis

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @erlend-aasland

@erlend-aasland
Copy link
Contributor Author

Thank you for your reviews, CAM and Kenny Chen! 🎉

@erlend-aasland erlend-aasland merged commit 16c33a9 into python:main Sep 15, 2022
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the sqlite-docs/clarify-txn-ctl branch September 15, 2022 21:11
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 15, 2022
… transactions (pythonGH-96832)

(cherry picked from commit 16c33a9)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 15, 2022
@bedevere-bot
Copy link

GH-96854 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 15, 2022
… transactions (pythonGH-96832)

(cherry picked from commit 16c33a9)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot
Copy link

GH-96855 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 15, 2022
miss-islington added a commit that referenced this pull request Sep 15, 2022
…actions (GH-96832)

(cherry picked from commit 16c33a9)

Co-authored-by: Erlend E. Aasland <[email protected]>
miss-islington added a commit that referenced this pull request Sep 15, 2022
…actions (GH-96832)

(cherry picked from commit 16c33a9)

Co-authored-by: Erlend E. Aasland <[email protected]>
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
…actions (GH-96832)

(cherry picked from commit 16c33a9)

Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlite3 docs: clarify transaction control for SELECT
4 participants