bpo-29556: Remove unused #include <langinfo.h> #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
approved these changes
Feb 14, 2017
|
Sorry, but seems there are more. Please give me some time to check them one by one. |
yan12125
changed the title
|
Still LGTM. Thanks for the commit numbers, it helped me to validate your change. |
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 9, 2017
… safe_pickle.c pickle_callback(). The bug is very old and might affect multiprocessing. The change fixes the bug and adds a test case. https://bitbucket.org/stackless-dev/stackless/issues/98 (grafted from 7cd2a4e39aa757427ccbf176ef7a0cd6f8f1514e)
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 9, 2017
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 9, 2017
…ed without threads. The test case needs threding. https://bitbucket.org/stackless-dev/stackless/issues/98 (grafted from 16c5769adf70810e23d480a51dddc60f34384251)
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 9, 2017
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 9, 2017
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
jaraco
added a commit
to jaraco/cpython
that referenced
this pull request
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This #include is added in b744ba1 (issue8610) and later the use of CODESET is removed in d64e8a7 (issue9642).
Found this in investigating issue29436
This is a minor fix but my first patch on Github. Hope everything works :)