Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link "Copyright" at the footer of the devguide. #653

Closed
Mariatta opened this issue Jan 14, 2021 · 5 comments
Closed

Broken link "Copyright" at the footer of the devguide. #653

Mariatta opened this issue Jan 14, 2021 · 5 comments
Labels
bug

Comments

@Mariatta
Copy link
Member

At the bottom of the Devguide, there is a link to Copyright that points to https://devguide.python.org/copyright/ which doesn't exist.

It would be great to fix that. Not even sure where it should go. Should it just point to the license? https://github.com/python/devguide/blob/master/LICENSE
Screen Shot 2021-01-14 at 8 39 28 AM
@Mariatta Mariatta added the bug label Jan 14, 2021
@Mariatta
Copy link
Member Author

This is implemented in python-docs-theme.
https://github.com/python/python-docs-theme/blob/c7c7b4014d620b4d6ad69d12f41bf2bbca454b08/python_docs_theme/layout.html#L48

@marvlyngkhoi
Copy link

Hey can I take this? If it's still open

@Mariatta
Copy link
Member Author

Mariatta commented Mar 4, 2021

If you can fix it, then you can work on it.

@jablonskidev jablonskidev mentioned this issue Mar 7, 2021
Closed
@CAM-Gerlach CAM-Gerlach mentioned this issue Mar 13, 2021
Merged
jablonskidev added a commit to jablonskidev/devguide that referenced this issue Mar 20, 2021
@jablonskidev
Added copyright link for the devguide
ce0e204 
In order to resolve issues python#652 and python#653 in the devguide (which are duplicates of each other), we added a theme variable to `python_docs_theme/layout.html` in PR python#67. This will allow all users of the python-docs-theme library to have more functionality and backwards compatibility. In addition, if users don't define a link for copyright information, then they won't have a broken link that leads to nowhere in their page footer.

In order to have the correct copyright link for the devguide specifically, we just needed to specify it in the `html_theme_options` dictionary in the devguide's `conf.py`, which I did in this commit.
@jablonskidev jablonskidev mentioned this issue Mar 20, 2021
Closed
@Ahmedk-n
Copy link

Hey can I work on that?

@hugovk
Copy link
Member

hugovk commented Jan 27, 2022 •
edited
Loading

This is now fixed:

image

@hugovk hugovk closed this as completed Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hugovk @Mariatta @Ahmedk-n @marvlyngkhoi