-
-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a quick reference for rst markup. #916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this PR is definitely a great improvement from a reader quick-reference perspective.
I do think, like for PEP 12, we shouldn't duplicate the Sphinx reST primer nearly word for word in most places, as opposed to just linking to it (via Intersphinx) and focusing on the guidance and conventions unique and specific to the CPython docs. I've opened python/docs-community#57 to discuss that issue further.
I didn't add methods/classes as discussed in a previous comment. The goal of this table is to provide a quick reminder for the syntax (e.g. how do I create a link? or a coment? was it Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall with your changes 👍 , I just had some textual improvements, minor nits and bikeshedding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested some re-writes to the roles section to avoid parts that are contradictory, duplicative and potentially confusing. Otherwise, this looks pretty good overall.
Co-authored-by: CAM Gerlach <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two tiny tweaks, otherwise LGTM 👍
Co-authored-by: CAM Gerlach <[email protected]>
Merged. thanks for the review and suggestions! |
This PR adds a quick reference table at the top of the rst reference page. The goal of this table is to show some commonly used markup and to include links to the relevant sections. I also added some internal references and changed a title.
This was proposed a decade ago on IRC, and then captured in python/cpython#58426 (comment) 1
Footnotes
note that the issue itself (now transferred to include rendered output in addition to markup #14) is probably obsolete, and this proposal doesn't aim to solve that. ↩