Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo to docs site #91

Closed
wants to merge 2 commits into from
Closed

Add logo to docs site #91

wants to merge 2 commits into from

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 23, 2023

Adds the one used for the Discord.

So instead of the default RTD icon we get a favicon that's also distinct from the other Python sites:

image


📚 Documentation preview 📚: https://docs-community--91.org.readthedocs.build/en/91/

@egeakman
Copy link
Contributor

egeakman commented Oct 23, 2023

I think a transparent background on the logo might look better

@egeakman
Copy link
Contributor

I can't upload webp here so here is the png. I can send the webp to you or open a new pull request

docs-community-logo-transparent

@hugovk
Copy link
Member Author

hugovk commented Oct 23, 2023

Please could you zip the webp? It should upload then.

@egeakman
Copy link
Contributor

@egeakman
Copy link
Contributor

egeakman commented Oct 23, 2023

Looks good to me 👍

image

@ezio-melotti
Copy link
Member

The black feather doesn't have much contrast with the black background.

Maybe it could be outlined or a semi transparent background could be added instead? Having an opaque circular background might also be an option.

@hugovk
Copy link
Member Author

hugovk commented Oct 23, 2023

Something like this?

image

@egeakman
Copy link
Contributor

egeakman commented Oct 23, 2023

Something like this?

--

I'm OK with both versions, but a dark mode user probably wouldn't appreciate the shine on the logo :D What do you guys think about an outer stroke on the feather? Any ideas on the stroke size, transparency, etc.?

image

@bskinn
Copy link

bskinn commented Oct 23, 2023

Drive-by opinion, I think the white outer stroke is a much better option than adding the white field. The quill is still poorly defined against the white field, even though it's easier to tell that it's a quill & inkpot.

I like this one with the white stroke quite a bit. That stroke width seems good... a bit of transparency on the stroke seems like a good thing to try, it might help it blend into the Python logo a bit better.

@CAM-Gerlach
Copy link
Member

Per the PSF Trademark Guidelines, given this is a public site with a derived logo ,and the feather directly impinges inside the Python logomark, it would probably be advisable for @malemburg and the PSF trademarks committee to give this a look before merging.

@malemburg
Copy link
Member

Per the PSF Trademark Guidelines, given this is a public site with a derived logo ,and the feather directly impinges inside the Python logomark, it would probably be advisable for @malemburg and the PSF trademarks committee to give this a look before merging.

Please send the logo to the TM committee at [email protected] to get approval. As @CAM-Gerlach already mentioned, we won't be able to approve this variant. The feather will have to be fully separated from the Python logo, or placed inside one of the snakes.

@hugovk
Copy link
Member Author

hugovk commented Oct 24, 2023

Thanks for checking! Let's close this.

@CAM-Gerlach Please could you remove it from Discord too, maybe replace with the standard logo?

@hugovk hugovk closed this Oct 24, 2023
@hugovk hugovk deleted the add-logo branch October 24, 2023 07:59
@malemburg
Copy link
Member

Uhm, I did not mean to spoil the fun. The logo looks nice, we'd just need to do a few iterations with the TM committee to make it compliant.

@hugovk
Copy link
Member Author

hugovk commented Oct 24, 2023

No problem! We can iterate and re-open when we have something ready and approved :) Thanks!

@CAM-Gerlach
Copy link
Member

@CAM-Gerlach Please could you remove it from Discord too, maybe replace with the standard logo?

Since the Discord is a quasi-private community not publicly visible without an invite link as opposed to a public-facing website visible to the wider world, and at this point suddenly changing it temporarily would likely create more consumer confusion then it would prevent (between the Python Docs discord and the Python core dev Discord, since they would suddenly have the same icon and the icon is the only visible-by-default disambguator between Discord servers), I would prefer if we could just wait a bit more to replace it with whatever conforming and approved variation we come up with, if possible.

@hugovk hugovk mentioned this pull request Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants