Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTD preview message rendering #93

Closed
wants to merge 1 commit into from

Conversation

egeakman
Copy link
Contributor

@egeakman egeakman commented Dec 12, 2023

See: readthedocs/actions#34 (comment)

PS: pre-commit is failing because of pypa/hatch#1113

@ofek
Copy link

ofek commented Dec 12, 2023

PS: pre-commit is failing because of pypa/hatch#1113

sphinx-contrib/sphinx-lint#106

@hugovk
Copy link
Member

hugovk commented Dec 12, 2023

Thanks for the PR! Let's wait a little bit, I'd prefer an upstream fix at https://github.com/readthedocs/actions so we don't need to apply this to all the repos.

@egeakman
Copy link
Contributor Author

egeakman commented Dec 12, 2023

Thanks for the PR! Let's wait a little bit, I'd prefer an upstream fix at https://github.com/readthedocs/actions so we don't need to apply this to all the repos.

Alright! The fix is at readthedocs/actions#32, if anyone's wondering. Though the RTD team can not reproduce the fix right now.

@egeakman
Copy link
Contributor Author

Closing the PR for now

@egeakman egeakman closed this Dec 12, 2023
@egeakman egeakman reopened this Dec 12, 2023
@egeakman egeakman closed this Dec 12, 2023
@egeakman egeakman deleted the fix-rtd-message branch December 25, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants