Skip to content

Commit

Permalink
Fix sidebar logo not loading in HTML docs (#12939)
Browse files Browse the repository at this point in the history
The mypy logo wasn't loading on https://mypy.readthedocs.io/ because
it's referenced via an http:// (not https) URL. The logo's URL is
http://mypy-lang.org/static/mypy_light.svg; that server is not
accessible via https, so I've moved mypy_light.svg into docs/source and
referenced it from there.

The project README also referenced the logo via the same URL, so for
consistency, the README now points at the same logo file in docs/source.
(Although the README's logo did load because GitHub proxies external
resources referenced in markdown files).
  • Loading branch information
h4l authored Jun 5, 2022
1 parent 8153e47 commit 9611e2d
Show file tree
Hide file tree
Showing 3 changed files with 101 additions and 2 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<img src="http://mypy-lang.org/static/mypy_light.svg" alt="mypy logo" width="300px"/>
<img src="docs/source/mypy_light.svg" alt="mypy logo" width="300px"/>

Mypy: Static Typing for Python
=======================================
Expand Down
2 changes: 1 addition & 1 deletion docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@

# The name of an image file (relative to this directory) to place at the top
# of the sidebar.
html_logo = "http://mypy-lang.org/static/mypy_light.svg"
html_logo = "mypy_light.svg"

# The name of an image file (within the static path) to use as favicon of the
# docs. This file should be a Windows icon file (.ico) being 16x16 or 32x32
Expand Down
99 changes: 99 additions & 0 deletions docs/source/mypy_light.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 9611e2d

Please sign in to comment.