Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed analysis.py is still used in ./mypyc/transform/uninit.py #9584

Closed
doko42 opened this issue Oct 12, 2020 · 5 comments · Fixed by #9587
Closed

removed analysis.py is still used in ./mypyc/transform/uninit.py #9584

doko42 opened this issue Oct 12, 2020 · 5 comments · Fixed by #9587
Labels
bug mypy got something wrong

Comments

@doko42
Copy link
Member

doko42 commented Oct 12, 2020

seen when trying to generate manual pages with 0.790 and python3.9:

I: pybuild base:217: /usr/bin/python3.9 setup.py build
Traceback (most recent call last):
File "/packages/tmp/mypy-0.790/setup.py", line 144, in
from mypyc.build import mypycify
File "/packages/tmp/mypy-0.790/mypyc/build.py", line 43, in
from mypyc.codegen import emitmodule
File "/packages/tmp/mypy-0.790/mypyc/codegen/emitmodule.py", line 41, in
from mypyc.transform.uninit import insert_uninit_checks
File "/packages/tmp/mypy-0.790/mypyc/transform/uninit.py", line 5, in
from mypyc.analysis.dataflow import (
ModuleNotFoundError: No module named 'mypyc.analysis'

apparently the analysis module was removed, however mypyc/transform/uninit.py still uses it

@doko42 doko42 added the bug mypy got something wrong label Oct 12, 2020
@hauntsaninja
Copy link
Collaborator

https://github.com/python/mypy/tree/master/mypyc/analysis still exists
I can't repro with python3.9 setup.py build on master, so closing. Feel free to reopen with more details :-)

JelleZijlstra added a commit that referenced this issue Oct 13, 2020
Fixes #9584 

I haven't tested myself but this package should probably be here.
@JelleZijlstra
Copy link
Member

I haven't tried to repro this, but noticed that mypyc.analysis is missing from setup.py, so I submitted a PR to fix it.

@JelleZijlstra JelleZijlstra reopened this Oct 13, 2020
@doko42
Copy link
Member Author

doko42 commented Oct 13, 2020

re-adding this module lets the build continue, and then it fails with (building from the release tarball):

mypy/fastparse.py:1260: error: "ExtSlice" has no attribute "dims"
mypy/fastparse.py:1264: error: "Index" has no attribute "value"

TH3CHARLie pushed a commit that referenced this issue Oct 13, 2020
@TH3CHARLie
Copy link
Collaborator

re-adding this module lets the build continue, and then it fails with (building from the release tarball):

mypy/fastparse.py:1260: error: "ExtSlice" has no attribute "dims"
mypy/fastparse.py:1264: error: "Index" has no attribute "value"

I think these errors are not related to the PR which closes this issue, these failures, I guess, are related to typeshed, maybe @hauntsaninja has some insight on this.

@hauntsaninja
Copy link
Collaborator

I fixed these last week in #9552 and #9562. If you pull those in, compiling with mypyc works.
(Note that 0.790 doesn't officially support 3.9 — https://mypy-lang.blogspot.com/2020/10/mypy-0790-released.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug mypy got something wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants