Support new union syntax in stubs always in runtime context #10771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it only worked when the target Python version was 3.10. Work on #9880.
ilevkivskyi
approved these changes
Jul 6, 2021
| @@ -143,7 +143,7 @@ def __init__(self, | |||
| self.nesting_level = 0 | |||
| # Should we allow unnormalized types like `list[int]` | |||
| # (currently allowed in stubs)? | |||
| self.allow_unnormalized = allow_unnormalized | |||
There was a problem hiding this comment.
Update the comment above to reflect the new name?
| accept_items(e.left) | ||
| accept_items(e.right) | ||
| else: | ||
| self.expr_checker.accept(e) |
There was a problem hiding this comment.
TBH I am not sure how this logic work correctly for A = list[int | None], maybe add a short comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it only worked when the target Python version was 3.10. Now type
aliases like these work in stubs on all Python versions:
Since type objects don't support
__or__before 3.10 (in typeshed), skip sometype checking of type alias definitions in stubs. Defensively only skip these things
in stubs, even though they could be redundant in other contexts as well.
Work on #9880.