[mypyc] Fix invalid unlikely() in certain rare branches #11939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we switch true/false branches, we also need to switch between likely/unlikely. This has an impact at least on accessing module-level final attributes with non-constant initializers. I couldn't see a significant difference in benchmark results on master, but this seems to help together with some other work-in-progress improvements I have been working on.
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
If we switch true/false branches, we also need to switch between likely/unlikely. This has an impact at least on accessing module-level final attributes with non-constant initializers. I couldn't see a significant difference in benchmark results compared to master, but this seems to help together with some other work-in-progress improvements I have been working on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we switch true/false branches, we also need to switch between
likely/unlikely.
This has an impact at least on accessing module-level final attributes
with non-constant initializers. I couldn't see a significant
difference in benchmark results compare to master, but this seems to
help together with some other work-in-progress improvements I have
been working on (and the old behavior was clearly wrong).