Ensure builtin modules are from typeshed sooner #13155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-of-kpp
force-pushed
the
typing-not-from-typeshed
branch
2 times, most recently
from
9d42785 to
d40f6d4
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
emmatyping
reviewed
Jul 16, 2022
code-of-kpp
force-pushed
the
typing-not-from-typeshed
branch
2 times, most recently
from
0ba3d21 to
d7227b3
Compare
code-of-kpp
force-pushed
the
typing-not-from-typeshed
branch
from
d7227b3 to
3d2f8a2
Compare
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
code-of-kpp
force-pushed
the
typing-not-from-typeshed
branch
from
3d2f8a2 to
15617d1
Compare
This comment has been minimized.
This comment has been minimized.
code-of-kpp
force-pushed
the
typing-not-from-typeshed
branch
from
15617d1 to
0dfa86e
Compare
This comment has been minimized.
This comment has been minimized.
code-of-kpp
force-pushed
the
typing-not-from-typeshed
branch
2 times, most recently
from
61f92e6 to
087db77
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
code-of-kpp
force-pushed
the
typing-not-from-typeshed
branch
3 times, most recently
from
4980baa to
f520c57
Compare
This comment has been minimized.
This comment has been minimized.
code-of-kpp
force-pushed
the
typing-not-from-typeshed
branch
from
f520c57 to
fc20f99
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
code-of-kpp
force-pushed
the
typing-not-from-typeshed
branch
from
fc20f99 to
b231fd9
Compare
This comment has been minimized.
This comment has been minimized.
code-of-kpp
force-pushed
the
typing-not-from-typeshed
branch
from
b231fd9 to
1549fa8
Compare
|
Hello, @mr-c! We've noticed that this PR will break Please note, that the structure of |
This comment has been minimized.
This comment has been minimized.
|
@JukkaL: just to double-check with you that custom typeshed is OK to be checked by mypy by default, because as you can see, it can cause some pain. |
|
But I'd say, it'd be better to do another PR later to somehow control this behavior |
|
Thanks for the notification! That folder isn't meant to be an entire typeshed, but just our local custom type hints. What name do you suggest that we use? |
What about |
mr-c
added a commit
to common-workflow-language/cwl-upgrader
that referenced
this pull request
Jul 20, 2022
mr-c
added a commit
to common-workflow-language/cwl-upgrader
that referenced
this pull request
Jul 20, 2022
as per python/mypy#13155 (comment) Set more accurate minimum versions for ruamel-yaml
mr-c
added a commit
to common-workflow-language/cwl-upgrader
that referenced
this pull request
Jul 20, 2022
as per python/mypy#13155 (comment) Set more accurate minimum versions for ruamel-yaml
|
@podshumok It looks like this now has merge conflict (maybe because of black), could you please resolve? |
It should work now with custom-typeshed-dir. Fixes python#1876
code-of-kpp
force-pushed
the
typing-not-from-typeshed
branch
from
2fcb933 to
f1a2722
Compare
|
@ilevkivskyi done |
|
Diff from mypy_primer, showing the effect of this PR on open source code: cwltool (https://github.com/common-workflow-language/cwltool)
+ typeshed/galaxy/util/__init__.pyi:7: note: In module imported here,
+ typeshed/galaxy/tool_util/deps/commands.pyi:6: note: ... from here,
+ typeshed/galaxy/tool_util/deps/docker_util.pyi:6: note: ... from here,
+ typeshed/galaxy/tool_util/deps/containers.pyi:10: note: ... from here,
+ cwltool/software_requirements.py:138: note: ... from here:
+ typeshed/galaxy/util/inflection.pyi: note: In member "cond_plural" of class "Base":
+ typeshed/galaxy/util/inflection.pyi:8:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "titleize" of class "Base":
+ typeshed/galaxy/util/inflection.pyi:9:5: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi:9:5: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "camelize" of class "Base":
+ typeshed/galaxy/util/inflection.pyi:10:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "underscore" of class "Base":
+ typeshed/galaxy/util/inflection.pyi:11:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "humanize" of class "Base":
+ typeshed/galaxy/util/inflection.pyi:12:5: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi:12:5: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "variablize" of class "Base":
+ typeshed/galaxy/util/inflection.pyi:13:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "tableize" of class "Base":
+ typeshed/galaxy/util/inflection.pyi:14:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "classify" of class "Base":
+ typeshed/galaxy/util/inflection.pyi:15:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "ordinalize" of class "Base":
+ typeshed/galaxy/util/inflection.pyi:16:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "unaccent" of class "Base":
+ typeshed/galaxy/util/inflection.pyi:17:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "string_replace" of class "Base":
+ typeshed/galaxy/util/inflection.pyi:18:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "urlize" of class "Base":
+ typeshed/galaxy/util/inflection.pyi:19:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "demodulize" of class "Base":
+ typeshed/galaxy/util/inflection.pyi:20:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "modulize" of class "Base":
+ typeshed/galaxy/util/inflection.pyi:21:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "foreignKey" of class "Base":
+ typeshed/galaxy/util/inflection.pyi:22:5: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi:22:5: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "pluralize" of class "English":
+ typeshed/galaxy/util/inflection.pyi:25:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "singularize" of class "English":
+ typeshed/galaxy/util/inflection.pyi:26:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "pluralize" of class "Inflector":
+ typeshed/galaxy/util/inflection.pyi:31:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "singularize" of class "Inflector":
+ typeshed/galaxy/util/inflection.pyi:32:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "cond_plural" of class "Inflector":
+ typeshed/galaxy/util/inflection.pyi:33:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "titleize" of class "Inflector":
+ typeshed/galaxy/util/inflection.pyi:34:5: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi:34:5: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "camelize" of class "Inflector":
+ typeshed/galaxy/util/inflection.pyi:35:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "underscore" of class "Inflector":
+ typeshed/galaxy/util/inflection.pyi:36:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "humanize" of class "Inflector":
+ typeshed/galaxy/util/inflection.pyi:37:5: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi:37:5: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "variablize" of class "Inflector":
+ typeshed/galaxy/util/inflection.pyi:38:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "tableize" of class "Inflector":
+ typeshed/galaxy/util/inflection.pyi:39:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "classify" of class "Inflector":
+ typeshed/galaxy/util/inflection.pyi:40:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "ordinalize" of class "Inflector":
+ typeshed/galaxy/util/inflection.pyi:41:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "unaccent" of class "Inflector":
+ typeshed/galaxy/util/inflection.pyi:42:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "urlize" of class "Inflector":
+ typeshed/galaxy/util/inflection.pyi:43:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "demodulize" of class "Inflector":
+ typeshed/galaxy/util/inflection.pyi:44:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "modulize" of class "Inflector":
+ typeshed/galaxy/util/inflection.pyi:45:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi: note: In member "foreignKey" of class "Inflector":
+ typeshed/galaxy/util/inflection.pyi:46:5: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/galaxy/util/inflection.pyi:46:5: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/cachecontrol/adapter.pyi:11: note: In module imported here,
+ typeshed/cachecontrol/wrapper.pyi:7: note: ... from here,
+ typeshed/cachecontrol/__init__.pyi:7: note: ... from here,
+ cwltool/utils.py:40: note: ... from here:
+ typeshed/cachecontrol/filewrapper.pyi: note: In member "__init__" of class "CallbackFileWrapper":
+ typeshed/cachecontrol/filewrapper.pyi:6:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/cachecontrol/filewrapper.pyi: note: In member "__getattr__" of class "CallbackFileWrapper":
+ typeshed/cachecontrol/filewrapper.pyi:7:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/cachecontrol/filewrapper.pyi: note: In member "read" of class "CallbackFileWrapper":
+ typeshed/cachecontrol/filewrapper.pyi:8:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/resolvers/resolver_mixins.pyi:6: note: In module imported here,
+ typeshed/galaxy/tool_util/deps/resolvers/galaxy_packages.pyi:6: note: ... from here,
+ typeshed/galaxy/tool_util/deps/__init__.pyi:9: note: ... from here,
+ cwltool/software_requirements.py:23: note: ... from here:
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In member "from_args" of class "RecipeContext":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:23:5: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:23:5: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In member "__init__" of class "RecipeContext":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:27:5: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In member "cellar_path" of class "RecipeContext":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:29:5: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:29:5: note: Use "-> None" if function does not return a value
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In member "tap_path" of class "RecipeContext":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:31:5: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:31:5: note: Use "-> None" if function does not return a value
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "main":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:33:1: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:33:1: note: Use "-> None" if function does not return a value
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In member "__init__" of class "CommandLineException":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:40:5: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "versioned_install":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:42:1: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:42:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "commit_for_version":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:43:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "print_versioned_deps":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:44:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "load_versioned_deps":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:45:1: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:45:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "unversioned_install":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:46:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "attempt_unlink_all":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:47:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "attempt_unlink":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:48:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "brew_execute":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:49:1: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:49:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "build_env_statements_from_recipe_context":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:50:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "build_env_statements":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:51:1: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:51:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "build_env_actions":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:52:1: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:52:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In member "__init__" of class "EnvAction":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:58:5: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In member "build_env" of class "EnvAction":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:60:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In member "modify_environ" of class "EnvAction":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:61:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In member "to_statements" of class "EnvAction":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:62:5: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:62:5: note: Use "-> None" if function does not return a value
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "brew_head_at_version":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:64:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "brew_head_at_commit":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:65:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "git_execute":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:66:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "execute":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:67:1: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:67:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "brew_deps":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:68:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "brew_info":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:69:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "extended_brew_info":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:70:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "brew_versions_info":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:71:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "recipe_cellar_path":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:72:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "ensure_brew_on_path":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:73:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi: note: In function "which":
+ typeshed/galaxy/tool_util/deps/brew_exts.pyi:74:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/cachecontrol/caches/file_cache.pyi:7: note: In module imported here,
+ typeshed/cachecontrol/caches/__init__.pyi:7: note: ... from here,
+ cwltool/utils.py:41: note: ... from here:
+ typeshed/cachecontrol/controller.pyi: note: In function "parse_uri":
+ typeshed/cachecontrol/controller.pyi:13:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/cachecontrol/controller.pyi: note: In member "__init__" of class "CacheController":
+ typeshed/cachecontrol/controller.pyi:19:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/cachecontrol/controller.pyi: note: In member "cache_url" of class "CacheController":
+ typeshed/cachecontrol/controller.pyi:21:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/cachecontrol/controller.pyi: note: In member "parse_cache_control" of class "CacheController":
+ typeshed/cachecontrol/controller.pyi:22:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/cachecontrol/controller.pyi: note: In member "cached_request" of class "CacheController":
+ typeshed/cachecontrol/controller.pyi:23:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/cachecontrol/controller.pyi: note: In member "conditional_headers" of class "CacheController":
+ typeshed/cachecontrol/controller.pyi:24:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/cachecontrol/controller.pyi: note: In member "cache_response" of class "CacheController":
+ typeshed/cachecontrol/controller.pyi:25:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/cachecontrol/controller.pyi: note: In member "update_cached_response" of class "CacheController":
+ typeshed/cachecontrol/controller.pyi:26:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/cachecontrol/caches/file_cache.pyi:6: note: In module imported here,
+ typeshed/cachecontrol/caches/__init__.pyi:7: note: ... from here,
+ cwltool/utils.py:41: note: ... from here:
+ typeshed/cachecontrol/cache.pyi: note: In member "get" of class "BaseCache":
+ typeshed/cachecontrol/cache.pyi:8:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/cachecontrol/cache.pyi: note: In member "set" of class "BaseCache":
+ typeshed/cachecontrol/cache.pyi:9:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/cachecontrol/cache.pyi: note: In member "delete" of class "BaseCache":
+ typeshed/cachecontrol/cache.pyi:10:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/cachecontrol/cache.pyi: note: In member "close" of class "BaseCache":
+ typeshed/cachecontrol/cache.pyi:11:5: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/cachecontrol/cache.pyi:11:5: note: Use "-> None" if function does not return a value
+ typeshed/cachecontrol/cache.pyi: note: In member "__init__" of class "DictCache":
+ typeshed/cachecontrol/cache.pyi:16:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/cachecontrol/cache.pyi: note: In member "get" of class "DictCache":
+ typeshed/cachecontrol/cache.pyi:17:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/cachecontrol/cache.pyi: note: In member "set" of class "DictCache":
+ typeshed/cachecontrol/cache.pyi:18:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/cachecontrol/cache.pyi: note: In member "delete" of class "DictCache":
+ typeshed/cachecontrol/cache.pyi:19:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/resolvers/__init__.pyi:6: note: In module imported here,
+ typeshed/galaxy/tool_util/deps/__init__.pyi:7: note: ... from here,
+ cwltool/software_requirements.py:23: note: ... from here:
+ typeshed/galaxy/util/dictifiable.pyi: note: In member "to_dict" of class "Dictifiable":
+ typeshed/galaxy/util/dictifiable.pyi:8:5: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/containers.pyi:11: note: In module imported here,
+ cwltool/software_requirements.py:138: note: ... from here:
+ typeshed/galaxy/tool_util/deps/singularity_util.pyi: note: In function "build_singularity_run_command":
+ typeshed/galaxy/tool_util/deps/singularity_util.pyi:7:1: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/galaxy/tool_util/deps/singularity_util.pyi:7:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/rdflib/__init__.pyi:2: note: In module imported here,
+ cwltool/builder.py:18: note: ... from here:
+ typeshed/rdflib/container.pyi: note: In member "__init__" of class "Container":
+ typeshed/rdflib/container.pyi:6:5: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/rdflib/container.pyi: note: In member "n3" of class "Container":
+ typeshed/rdflib/container.pyi:7:5: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/rdflib/container.pyi:7:5: note: Use "-> None" if function does not return a value
+ typeshed/rdflib/container.pyi: note: In member "__len__" of class "Container":
+ typeshed/rdflib/container.pyi:8:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/rdflib/container.pyi: note: In member "type_of_conatiner" of class "Container":
+ typeshed/rdflib/container.pyi:9:5: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/rdflib/container.pyi:9:5: note: Use "-> None" if function does not return a value
+ typeshed/rdflib/container.pyi: note: In member "index" of class "Container":
+ typeshed/rdflib/container.pyi:10:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/rdflib/container.pyi: note: In member "__getitem__" of class "Container":
+ typeshed/rdflib/container.pyi:11:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/rdflib/container.pyi: note: In member "__setitem__" of class "Container":
+ typeshed/rdflib/container.pyi:12:5: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/rdflib/container.pyi: note: In member "__delitem__" of class "Container":
+ typeshed/rdflib/container.pyi:13:5: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/rdflib/container.pyi: note: In member "items" of class "Container":
+ typeshed/rdflib/container.pyi:14:5: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/rdflib/container.pyi:14:5: note: Use "-> None" if function does not return a value
+ typeshed/rdflib/container.pyi: note: In member "end" of class "Container":
+ typeshed/rdflib/container.pyi:15:5: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/rdflib/container.pyi:15:5: note: Use "-> None" if function does not return a value
+ typeshed/rdflib/container.pyi: note: In member "append" of class "Container":
+ typeshed/rdflib/container.pyi:16:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/rdflib/container.pyi: note: In member "append_multiple" of class "Container":
+ typeshed/rdflib/container.pyi:17:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/rdflib/container.pyi: note: In member "clear" of class "Container":
+ typeshed/rdflib/container.pyi:18:5: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/rdflib/container.pyi:18:5: note: Use "-> None" if function does not return a value
+ typeshed/rdflib/container.pyi: note: In member "__init__" of class "Bag":
+ typeshed/rdflib/container.pyi:21:5: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/rdflib/container.pyi: note: In member "__init__" of class "Alt":
+ typeshed/rdflib/container.pyi:24:5: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/rdflib/container.pyi: note: In member "anyone" of class "Alt":
+ typeshed/rdflib/container.pyi:25:5: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/rdflib/container.pyi:25:5: note: Use "-> None" if function does not return a value
+ typeshed/rdflib/container.pyi: note: In member "__init__" of class "Seq":
+ typeshed/rdflib/container.pyi:28:5: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/rdflib/container.pyi: note: In member "add_at_position" of class "Seq":
+ typeshed/rdflib/container.pyi:29:5: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/rdflib/__init__.pyi:1: note: In module imported here,
+ cwltool/builder.py:18: note: ... from here:
+ typeshed/rdflib/util.pyi: note: In function "list2set":
+ typeshed/rdflib/util.pyi:3:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/rdflib/util.pyi: note: In function "first":
+ typeshed/rdflib/util.pyi:4:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/rdflib/util.pyi: note: In function "uniq":
+ typeshed/rdflib/util.pyi:5:1: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/rdflib/util.pyi:5:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/rdflib/util.pyi: note: In function "more_than":
+ typeshed/rdflib/util.pyi:6:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/rdflib/util.pyi: note: In function "to_term":
+ typeshed/rdflib/util.pyi:7:1: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/rdflib/util.pyi:7:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/rdflib/util.pyi: note: In function "from_n3":
+ typeshed/rdflib/util.pyi:8:1: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/rdflib/util.pyi: note: In function "check_context":
+ typeshed/rdflib/util.pyi:11:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/rdflib/util.pyi: note: In function "check_subject":
+ typeshed/rdflib/util.pyi:12:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/rdflib/util.pyi: note: In function "check_predicate":
+ typeshed/rdflib/util.pyi:13:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/rdflib/util.pyi: note: In function "check_object":
+ typeshed/rdflib/util.pyi:14:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/rdflib/util.pyi: note: In function "check_statement":
+ typeshed/rdflib/util.pyi:15:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/rdflib/util.pyi: note: In function "check_pattern":
+ typeshed/rdflib/util.pyi:16:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/rdflib/util.pyi: note: In function "date_time":
+ typeshed/rdflib/util.pyi:17:1: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/rdflib/util.pyi: note: In function "parse_date_time":
+ typeshed/rdflib/util.pyi:18:1: error: Function is missing a type annotation [no-untyped-def]
+ typeshed/rdflib/util.pyi: note: In function "guess_format":
+ typeshed/rdflib/util.pyi:19:1: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/rdflib/util.pyi:19:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/rdflib/util.pyi: note: In function "find_roots":
+ typeshed/rdflib/util.pyi:20:1: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/rdflib/util.pyi:20:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/rdflib/util.pyi: note: In function "get_tree":
+ typeshed/rdflib/util.pyi:21:1: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/rdflib/util.pyi:21:1: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/rdflib/term.pyi:3: note: In module imported here,
+ tests/test_provenance.py:14: note: ... from here:
+ typeshed/rdflib/paths.pyi: note: In member "eval" of class "Path":
+ typeshed/rdflib/paths.pyi:16:5: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
+ typeshed/rdflib/paths.pyi: note: In member "__hash__" of class "Path":
+ typeshed/rdflib/paths.pyi:17:5: error: Function is missing a return type annotation [no-untyped-def]
+ typeshed/rdflib/paths.pyi:17:5: note: Use "-> None" if function does not return a value
+ typeshed/rdflib/paths.pyi: note: In member "__eq__" of class "Path":
+ typeshed/rdflib/paths.pyi:18:5: error: Function is missing a type annotation [no-u
... (truncated 1611 lines) ... |
|
This also needs changes to setup.py |
mr-c
added a commit
to common-workflow-language/cwltool
that referenced
this pull request
Aug 1, 2022
mr-c
added a commit
to common-workflow-language/cwltool
that referenced
this pull request
Aug 1, 2022
mr-c
added a commit
to common-workflow-language/cwltool
that referenced
this pull request
Aug 1, 2022
* rename our local type stubs dir & fix types As per python/mypy#13155 (comment) * upgrade minimum ruamel.yaml versions
hauntsaninja
pushed a commit
that referenced
this pull request
Aug 1, 2022
ilevkivskyi
added a commit
that referenced
this pull request
Sep 8, 2022
This was broken by #13155, fix is straightforward, pass custom typeshed dir from options everywhere. Co-authored-by: Ivan Levkivskyi <[email protected]>
jhance
pushed a commit
that referenced
this pull request
Sep 9, 2022
This was broken by #13155, fix is straightforward, pass custom typeshed dir from options everywhere. Co-authored-by: Ivan Levkivskyi <[email protected]>
GlassOfWhiskey
pushed a commit
to common-workflow-language/cwltool
that referenced
this pull request
Sep 15, 2022
* rename our local type stubs dir & fix types As per python/mypy#13155 (comment) * upgrade minimum ruamel.yaml versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should work now with
custom-typeshed-diranduse_builtins_fixtures.Fixes #1876