Add pip as test requirement to support editable installs in tests with PEP 660 #15482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff from mypy_primer, showing the effect of this PR on open source code: graphql-core (https://github.com/graphql-python/graphql-core): typechecking got 1.06x slower (348.6s -> 368.7s)
(Performance measurements are based on a single noisy sample)
|
|
@hauntsaninja Should I add anything or can this be merged? Would like to know if the wheel build is really fixed after this. It should be 🤞🏻 |
|
Sorry, I think tests were still running when I approved. Merged now, thanks again for being on top of this! :-) |
cdce8p
added a commit
to cdce8p/mypy
that referenced
this pull request
Jun 22, 2023
…thon#15482)" This reverts commit 7d031be.
hauntsaninja
pushed a commit
that referenced
this pull request
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pip version
21.3is required to support editable installs with PEP 660. Currently, the mypy wheel build fails forcp38-macosx_x86_64with the following error:https://github.com/mypyc/mypy_mypyc-wheels/actions/runs/5323325694/jobs/9640999946#step:4:6103
https://pip.pypa.io/en/stable/news/#id232