Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stubs no longer in typeshed #18373

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

hauntsaninja
Copy link
Collaborator

See #18367 for script
See #18366 for additions

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/blocks/redis.py:6: error: Library stubs not installed for "redis.asyncio"  [import-untyped]
- src/prefect/blocks/redis.py:6: note: Hint: "python3 -m pip install types-redis"
- src/prefect/blocks/redis.py:6: note: (or run "mypy --install-types" to install all missing stub packages)
- src/prefect/blocks/redis.py:6: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
- src/prefect/blocks/redis.py:6: error: Library stubs not installed for "redis"  [import-untyped]
+ src/prefect/cli/deployment.py:708: note: (or run "mypy --install-types" to install all missing stub packages)
+ src/prefect/cli/deployment.py:708: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

sphinx (https://github.com/sphinx-doc/sphinx)
- sphinx/util/images.py:15:1: error: Library stubs not installed for "PIL"  [import-untyped]
+ sphinx/util/images.py:15:1: error: Cannot find implementation or library stub for module named "PIL"  [import-not-found]
+ sphinx/builders/_epub_base.py:32:1: error: Cannot find implementation or library stub for module named "PIL"  [import-not-found]
- sphinx/builders/_epub_base.py:32:1: error: Library stubs not installed for "PIL"  [import-untyped]
- sphinx/builders/_epub_base.py:32:1: note: Hint: "python3 -m pip install types-Pillow"

bokeh (https://github.com/bokeh/bokeh)
+ src/bokeh/io/export.py:50:1: error: Cannot find implementation or library stub for module named "PIL"  [import-not-found]
- src/bokeh/io/export.py:50:1: error: Library stubs not installed for "PIL"  [import-untyped]
- src/bokeh/io/export.py:50:1: note: Hint: "python3 -m pip install types-Pillow"

streamlit (https://github.com/streamlit/streamlit)
+ lib/streamlit/runtime/caching/hashing.py:473:1: error: Cannot find implementation or library stub for module named "PIL.Image"  [import-not-found]
- lib/streamlit/runtime/caching/hashing.py:473:1: error: Library stubs not installed for "PIL.Image"  [import-untyped]
- lib/streamlit/runtime/caching/hashing.py:473:1: note: Hint: "python3 -m pip install types-Pillow"
- lib/streamlit/runtime/caching/hashing.py:473:1: note: (or run "mypy --install-types" to install all missing stub packages)
- lib/tests/streamlit/elements/image_test.py:25:1: error: Library stubs not installed for "PIL.Image"  [import-untyped]
+ lib/tests/streamlit/elements/image_test.py:25:1: error: Cannot find implementation or library stub for module named "PIL.Image"  [import-not-found]

django-stubs (https://github.com/typeddjango/django-stubs)
+ django-stubs/core/cache/backends/redis.pyi:7: error: Cannot find implementation or library stub for module named "redis._parsers"  [import-not-found]
- django-stubs/core/cache/backends/redis.pyi:7: error: Library stubs not installed for "redis._parsers"  [import-untyped]
- django-stubs/core/cache/backends/redis.pyi:7: note: Hint: "python3 -m pip install types-redis"
- django-stubs/core/cache/backends/redis.pyi:7: note: (or run "mypy --install-types" to install all missing stub packages)
- django-stubs/core/cache/backends/redis.pyi:8: error: Library stubs not installed for "redis.client"  [import-untyped]
- django-stubs/core/cache/backends/redis.pyi:9: error: Library stubs not installed for "redis.connection"  [import-untyped]
+ django-stubs/core/cache/backends/redis.pyi:8: error: Cannot find implementation or library stub for module named "redis.client"  [import-not-found]
+ django-stubs/core/cache/backends/redis.pyi:9: error: Cannot find implementation or library stub for module named "redis.connection"  [import-not-found]

porcupine (https://github.com/Akuli/porcupine)
- porcupine/plugins/highlight/tree_sitter_highlighter.py:12: error: Library stubs not installed for "tree_sitter"  [import-untyped]
+ porcupine/plugins/highlight/tree_sitter_highlighter.py:12: error: Cannot find implementation or library stub for module named "tree_sitter"  [import-not-found]
- porcupine/plugins/highlight/tree_sitter_highlighter.py:12: note: Hint: "python3 -m pip install types-tree-sitter"

@hauntsaninja hauntsaninja merged commit 69ca89c into python:master Dec 30, 2024
18 checks passed
@hauntsaninja hauntsaninja deleted the stubs-removals branch December 30, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants