[stubgen] Include simple decorators in stub files #18489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdce8p
commented
Jan 19, 2025
Comment on lines
+349
to
+350
| @decorator(x=1, y={"a": 1}) | ||
| def foo_bar(x): ... |
There was a problem hiding this comment.
Decorator CallExpr are left for a future PR. For type checker to be able to infer the correct type, all arguments need to be passed along as well.
|
Yeah, re: history, I think the PEP 612 thing is right |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stubgen historically only included a selected number of decorators in the generated stubs. I couldn't find the actual reason for it, however it's likely fair to assume that decorator typing only started being possible with PEP 612 thus most had been untyped previously.
As it's fairly simple to annotate decorators with
ParamSpecnow, it's probably fair to include them in the stub file now.