[clean strict optional] Fix another 32 errors #3265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans
--strict-optional
for:There are still 2 errors in the last one, but one of them is a typeshed issue (will report it tomorrow), and another should be fixed when @elazarg will finish #1855.
There is something interesting that I have noticed: there are around 150 errors only because
Instance.type
has typeOptional[TypeInfo]
. However, it could beNone
only right after de-serialization. It seems that these 150 errors could be fixed either by tweaking de-serialization (use a temporary classNotReadyInstance
?) or just add "semi-automatically" some 150 asserts.