Add support for setuptools eggs with PEP 561 searching #5026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setuptools installs packages differently from wheels or normal distutils, using "eggs". Eggs have three main formats that differ from the normal method: editable, compressed, and uncompressed. This change adds support for editable and uncompressed egg installs. There is also a bug fix for some Linuxes (e.g. Ubuntu) listing nonexistent package directories...
emmatyping
force-pushed
the
eggsupport
branch
3 times, most recently
from
9d2b5c8 to
36b036b
Compare
|
Well, I am flummoxed why this is failing, clearly the package is installed (the type information is picked up), but pip cannot uninstall it? Seems like a pip bug (I can repro locally too). I'll poke at it tomorrow. |
|
Okay well, I've been told that expecting pip to deal well with eggs is not going to happen. I'm not sure how well I am going to be able to test this if that is the case. |
|
Based on more discussion with the packaging folks, I am first going to re-design how the pep561 tests are run, which will hopefully work around this issue. Instead of interacting with one site-packages, I will create a virtualenv for each test. This also allows me to parrallelize the tests, hopefully making them run a bit faster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setuptools installs packages differently from wheels or normal
distutils, using "eggs". Eggs have three main formats that differ from the
normal method: editable, compressed, and uncompressed. This change adds
support for editable and uncompressed egg installs.
Before reviewing I highly recommend reading https://github.com/pypa/setuptools/blob/master/docs/formats.txt which describes the egg format.
There is also a work around for the fact that Ubuntu (and I believe all Debian based Linuxes) list non-existent site-package directories...
This fixes much of #5007, I will work on compressed egg installs on the flight to Cleveland :)