More tweaks to support mypyc #5513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently pytest does its own thing for importing and doesn't load the C extension versions
ilevkivskyi
approved these changes
Aug 24, 2018
mypy/checkexpr.py
Outdated
| return UnionType([self.analyze_type_type_callee(item, context) | ||
| for item in item.relevant_items()], item.line) | ||
| return UnionType([self.analyze_type_type_callee(x, context) | ||
| for x in item.relevant_items()], item.line) |
There was a problem hiding this comment.
I would use a bit more descriptive name like tp instead of just x.
| @@ -191,7 +191,7 @@ def __init__(self) -> None: | |||
| self.use_builtins_fixtures = False | |||
|
|
|||
| # -- experimental options -- | |||
| self.shadow_file = None # type: Optional[List[Tuple[str, str]]] | |||
| self.shadow_file = None # type: Optional[List[List[str]]] | |||
There was a problem hiding this comment.
Hm, I am curious why mypy didn't catch any error about this?
There was a problem hiding this comment.
The field gets populated by argparse, I think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.