Remove deprecated options #5740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 4, 2018 17:28
All print a message; most are ignored except where marked: --disallow-any -f/--dirty-stubs --use-python-path (would exit with error message) -s/--silent-imports (would set ignore_missing_imports=True and follow_imports=skip) --almost-silent (would set follow_imports=error) --[no-]fast-parser
(Putting this in a separate commit since it's more controversial -- since it did work, some people might still be using it, even though it's been deprecated since May 2017. See discussion in python#3195.)
|
Regarding the strict-boolean flag -- maybe one idea might be to move that sort of logic into a separate plugin that's independent from mypy. I've been vaguely thinking about doing this myself, actually -- I can never remember what's supposed to be truthy or falsey from language to language, so most of my personal code is written in a style where this sort of plugin would actually be mildly useful/not very noisy. I'm not sure if our plugin system would support these kinds of extensions yet though. |
|
I don't think the plugin system could do that unless there was a way to
request being called for every expression.
|
|
Hm, it seems I did the wrong thing trying to make flake8 happy. Sorry! |
|
No worries, I'll fix it.
|
JukkaL
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will now all fail with
unrecognized arguments: <flag>I've put the removal of
--strict-booleanin a separate commit since it's more controversial -- some people might still be using it, even though it's been deprecated since May 2017. See discussion in #3195.