Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update attrs plugin to work with new semantic analyzer #6435

Merged
merged 4 commits into from
Feb 19, 2019
Merged

Update attrs plugin to work with new semantic analyzer #6435

merged 4 commits into from
Feb 19, 2019

Conversation

ilevkivskyi
Copy link
Member

No description provided.

@ilevkivskyi ilevkivskyi requested a review from JukkaL February 19, 2019 15:39
JukkaL
JukkaL reviewed Feb 19, 2019
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to have more tests enabled with the new semantic analyzer! Left just a few minor notes, otherwise looks good.

mypy/plugins/attrs.py Outdated Show resolved Hide resolved
mypy/checker.py Outdated Show resolved Hide resolved
test-data/unit/check-attr.test Show resolved Hide resolved
@ilevkivskyi ilevkivskyi mentioned this pull request Feb 19, 2019
Closed
@ilevkivskyi ilevkivskyi merged commit 02a06a1 into python:master Feb 19, 2019
@ilevkivskyi ilevkivskyi deleted the new-analyzer-attrs branch February 19, 2019 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilevkivskyi @JukkaL