Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New semantic analyzer: fix order=True in dataclass with deferral #6987

Merged
merged 1 commit into from
Jun 13, 2019
Merged

New semantic analyzer: fix order=True in dataclass with deferral #6987

merged 1 commit into from
Jun 13, 2019

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Jun 13, 2019

Fixes #6954.

@JukkaL JukkaL requested a review from ilevkivskyi June 13, 2019 14:03
ilevkivskyi
ilevkivskyi approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@ilevkivskyi ilevkivskyi merged commit 0fdfdc7 into master Jun 13, 2019
@ilevkivskyi ilevkivskyi deleted the semanal-plugin-methods branch June 13, 2019 15:26
PattenR pushed a commit to PattenR/mypy that referenced this pull request Jun 23, 2019
@JukkaL @PattenR
New semantic analyzer: fix order=True in dataclass with deferral (pyt…
1e5f9d8 
…hon#6987)

Fixes python#6954.
@JukkaL JukkaL mentioned this pull request Jul 11, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New semantic analyzer: plugin generated methods are confused with user defined ones
2 participants
@JukkaL @ilevkivskyi