Skip to content

Commit

Permalink
Infra: Add nicer 404 page (#4184)
Browse files Browse the repository at this point in the history
Co-authored-by: Adam Turner <[email protected]>
  • Loading branch information
hugovk and AA-Turner authored Dec 31, 2024
1 parent fc00ce6 commit 0a3e52c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ htmllive: _ensure-sphinx-autobuild html
.PHONY: dirhtml
dirhtml: BUILDER = dirhtml
dirhtml: html
mv $(BUILDDIR)/404/index.html $(BUILDDIR)/404.html

## linkcheck to check validity of links within PEP sources
.PHONY: linkcheck
Expand Down
5 changes: 5 additions & 0 deletions peps/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

# Add any Sphinx extension module names here, as strings.
extensions = [
"notfound.extension",
"pep_sphinx_extensions",
"sphinx.ext.extlinks",
"sphinx.ext.intersphinx",
Expand Down Expand Up @@ -85,6 +86,10 @@
"pypi": ("https://pypi.org/project/%s/", "%s"),
}

# sphinx-notfound-page
# https://sphinx-notfound-page.readthedocs.io/en/latest/faq.html#does-this-extension-work-with-github-pages
notfound_urls_prefix = None

# -- Options for HTML output -------------------------------------------------

_PSE_PATH = _ROOT / "pep_sphinx_extensions"
Expand Down
1 change: 1 addition & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Pygments >= 2.9.0
# See https://github.com/sphinx-doc/sphinx/pull/11100
Sphinx >= 5.1.1, != 6.1.0, != 6.1.1, < 8.1.0
docutils >= 0.19.0
sphinx-notfound-page >= 1.0.2

# For tests
pytest
Expand Down

0 comments on commit 0a3e52c

Please sign in to comment.