PEP 384: Update PyType_Spec struct per bpo-15140 #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
changed the title
gvanrossum
approved these changes
Apr 1, 2020
There was a problem hiding this comment.
Thanks for fixing this!
We usually don't update PEPs when the implementation changes after the PEP was accepted, but in this case it's different, given MvL's comment in the issue tracker. And since this PEP is used as a standard reference, I think fixing the signedness of the flags field is correct too.
|
You're welcome! |
mnm678
pushed a commit
to mnm678/peps
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue15140
In PEP 384, the PyType_Spec struct has "const char *doc" and "unsigned int flags" these is not present in the implementation (Include/object.h).