Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 682: small additions #2322

Merged
merged 7 commits into from
Feb 14, 2022
Merged

PEP 682: small additions #2322

merged 7 commits into from
Feb 14, 2022

Conversation

belm0
Copy link
Contributor

@belm0 belm0 commented Feb 13, 2022

  • clarify supported presentation types
  • cite Rust survey
  • note C99 use of z

@belm0 belm0 requested a review from mdickinson as a code owner February 13, 2022 12:17
mdickinson
mdickinson approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo the linter complaints about single backticks.

@belm0 belm0 force-pushed the signed_zero_format_r3 branch from 644114c to 9383e4a Compare February 13, 2022 12:23
@belm0
Copy link
Contributor Author

belm0 commented Feb 13, 2022

@gpshead would you take a look, as the changes reflect your suggestions?

AA-Turner
AA-Turner reviewed Feb 13, 2022
View reviewed changes
pep-0682.rst Outdated Show resolved Hide resolved
pep-0682.rst Outdated Show resolved Hide resolved
pep-0682.rst Outdated Show resolved Hide resolved
@AA-Turner
Copy link
Member

@belm0 Happy to merge, or can wait if you still want @gpshead to take a look.

A

@belm0
Copy link
Contributor Author

belm0 commented Feb 14, 2022

Thank you-- please go ahead and merge. If there are follow-up suggestions I'll do another PR.

@hugovk hugovk merged commit 88c6514 into python:main Feb 14, 2022
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@mdickinson mdickinson mdickinson approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@belm0 @AA-Turner @mdickinson @JelleZijlstra @hugovk @the-knights-who-say-ni