-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 654: add number of sub-exceptions to BaseException.__str__ #2356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a reason to bother the SC with this level of detail. If they don't like this they can comment on the PR or open a new bpo.
This change looks fine from an editor perspective; would you like to keep it open for some time to allow the Council to comment or are you happy for it to be merged? A |
Let's merge, we can always change it if there's an issue. |
Just FYI, @python/pep-editors , its probably a good idea to check for and fix PR titles to ensure they follow the standard |
I normally do this when merging commits rather than changing the title, but I generally agree (to the extent of labelling most of my infrastructure PRs under PEP 676!) A |
No description provided.