Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 655: Motivation: Enables mixed key requiredness in the TypedDict alternative syntax #2359

Merged
merged 4 commits into from
Feb 25, 2022

Conversation

davidfstr
Copy link
Contributor

Thanks for the related feedback @JelleZijlstra and Mehdi Drissi!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…alternative syntax
pep-0655.rst Outdated Show resolved Hide resolved
pep-0655.rst Outdated Show resolved Hide resolved
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor editorial nits

pep-0655.rst Show resolved Hide resolved
pep-0655.rst Outdated Show resolved Hide resolved
pep-0655.rst Outdated Show resolved Hide resolved
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>
@davidfstr
Copy link
Contributor Author

davidfstr commented Feb 25, 2022

All pending feedback is now integrated.

(I'm really liking this [new?] GitHub feature where specific diff changes can be proposed.)

@JelleZijlstra JelleZijlstra merged commit 71ace0e into python:main Feb 25, 2022
@CAM-Gerlach
Copy link
Member

(I'm really liking this [new?] GitHub feature where specific diff changes can be proposed.)

It has actually been around for a few years now, but yes, it is extremely useful for both authors and reviewers, particularly for applications such as this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants