PEP 683: Immortal Objects v3 #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra
approved these changes
Feb 28, 2022
AA-Turner
reviewed
Feb 28, 2022
AA-Turner
approved these changes
Feb 28, 2022
|
Thanks both, looks good! A |
|
@eduardo-elizondo, I'm going to merge this (and post to python-dev) soon unless you have any changes to include. |
eduardo-elizondo
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
I just went through all the changes. Huge thumbs up on my end, this definitely clarifies a bunch of the points that have been brought up in the various python-dev threads as well as leaving the implementation details open enough to keep iterating and improving this over time as long the initial change is close to perf neutral.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly changes in response to https://mail.python.org/archives/list/[email protected]/thread/KDAR6CCMPOX36GQJUDWHQBKRD5USNV3B/. Also, we increase the focus on the immutability of per-object runtime state.