Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 681: Describe CPython changes and include docs link #2390

Merged
merged 3 commits into from
Mar 9, 2022
Merged

PEP 681: Describe CPython changes and include docs link #2390

merged 3 commits into from
Mar 9, 2022

Conversation

debonte
Copy link
Contributor

@debonte debonte commented Mar 8, 2022

Responding to @encukou's feedback on Typing SIG

  • Added sentence in abstract explaining the PEP's impact on CPython
  • Added link in abstract to dataclasses documentation

@debonte debonte requested a review from JelleZijlstra as a code owner March 8, 2022 19:51
@JelleZijlstra JelleZijlstra self-assigned this Mar 8, 2022
CAM-Gerlach
CAM-Gerlach reviewed Mar 8, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One reST syntax tweak

pep-0681.rst Outdated Show resolved Hide resolved
@debonte @CAM-Gerlach
Make typing.py monospace
107acd6 
Co-authored-by: CAM Gerlach <[email protected]>
CAM-Gerlach
CAM-Gerlach approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from an uninvolved PEP editor perspective, thanks. Deferring to @JelleZijlstra for a more substantive review.

@JelleZijlstra JelleZijlstra merged commit 0dc3c49 into python:main Mar 9, 2022
@debonte debonte deleted the encukouFeedback branch March 9, 2022 21:18
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees

@JelleZijlstra JelleZijlstra

Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@debonte @CAM-Gerlach @JelleZijlstra @the-knights-who-say-ni