Styling: Remove field block highlights and restore definition list indent #2425
Conversation
|
https://pep-previews--2425.org.readthedocs.build/pep-0609/#terminology for a page with A |
There was a problem hiding this comment.
Unfortunately, this doesn't yet actually fix the problem reported in #2300 , and vertical margins are still pretty tight overall (as @pradyunsg reported), and there's also a contrast, consistency and accessibility issue with the changes to the header and footnotes styling. See comments for more on both and review suggestions to fix each of them.
Also, you might want to consider vertical rules between the definition list elements as well (perhaps --colour-rule-light ones) to help them and each element further stand out, and be a closer match to the original theme.
| @@ -122,9 +122,6 @@ pre { | |||
| dl dt { | |||
| font-weight: bold; | |||
| } | |||
| dl dd { | |||
| margin: 0; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
| dl dd { | |
| margin-bottom: 0.5rem; | |
| } |
Unfortunately, this doesn't fix the problem reported in #2300 , where the vertical margin varies substantially between entries with multiple paragraphs (i.e, another <p> element) and those that only have one. Furthermore, the margins are still pretty tight as @pradyunsg reported, making them uncomfortable to read; they should be at least equivalent to the normal margin between paragraph-level elements.
See PEP 639 for an example:
This resolves both of those concerns by just ensuring that dl dd (except headers and footnotes, which are already overridden) have the same 0.5rem bottom vertical margin as paragraphs do:
There was a problem hiding this comment.
Let's fix the line spacing in a follow up. It isn't limited to these dls. :)
There was a problem hiding this comment.
There are definitely other issues with line spacing, but this was one of the most immediately noticeable, and this particular issue is not just that the line spacing is too narrow but that is visibly inconsistent between definitions with multiple paragraphs and those with only a single one, so I'm not sure we should let the fact that there are also other issues with line spacing block fixing this one.
However, if we do this, this PR should be unmarked as resolving #2300 , because this was the initial problem that prompted and was cited in said issue.
|
I thought the issue with A |
A