Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 630: Add sections for 2 more gotchas #2450

Merged
merged 3 commits into from
Mar 21, 2022
Merged

Conversation

encukou
Copy link
Member

@encukou encukou commented Mar 21, 2022

Two more things to watch out for.

I'm almost ready to convert this PEP into a HOWTO page in the CPython docs. I'd welcome any copy-editing you can throw at it (preferably as a separate PR, which could be rebased onto the docs if the document moves there quickly).
If you don't speak C but want to copyedit, I'd be happy to explain the details.

@CAM-Gerlach
Copy link
Member

I'd welcome any copy-editing you can throw at it (preferably as a separate PR, which could be rebased onto the docs if the document moves there quickly).

Indeed; a separate PR would allow easily and consistently copyediting the full document, rather than just the sections added here. Looking over this I actually only spotted one clear issue, a straightforward typo. I'd suggest just fixing that here, and then once this is merged (presumably pretty soon), I can follow up with a copyedit of the whole document as a PR to this repo (for your review) rather than to your branch here, which would make things rather more complicated. Or, I can just go ahead with it now, if these changes won't be merged soon, since these changes are fairly self-contained.

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good already; I only noticed one clear issue, a simple typo, which I just made a suggestion for. Otherwise, I can help copyedit the rest of the document in another PR, either before or after this is merged (probably would be better, IMO, to merge this fairly promptly and iterate from there).

pep-0630.rst Outdated Show resolved Hide resolved
@encukou
Copy link
Member Author

encukou commented Mar 21, 2022

Indeed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants