Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 670: Rearrange and reword the PEP #2461

Merged
merged 3 commits into from
Mar 28, 2022
Merged

PEP 670: Rearrange and reword the PEP #2461

merged 3 commits into from
Mar 28, 2022

Conversation

encukou
Copy link
Member

@encukou encukou commented Mar 23, 2022

@vstinner & @erlend-aasland, this should make the PEP more understandable & complete

pep-0670.rst Show resolved Hide resolved
pep-0670.rst Outdated Show resolved Hide resolved
pep-0670.rst Outdated Show resolved Hide resolved
pep-0670.rst Outdated Show resolved Hide resolved
@vstinner vstinner requested a review from erlend-aasland March 23, 2022 17:52
@vstinner
Copy link
Member

Please wait for Erlend's (@erlend-aasland) approval, since he is one of two authors of this PEP :-) cc @erlend-aasland

Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICS, the major part of this PR is a rearrangement of some of the sections. I'm fine with that. The rewordings are ok to me as well.

Thanks Petr and Victor.

pep-0670.rst Show resolved Hide resolved
Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants