-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 11: Add Linux s390x to Tier 3 #2543
Conversation
@brettcannon: I would like to support Linux s390x with Fedora Stable GCC. Did I pick the correct platform triple format? I wrote in the long python-committers thread, so it got lots in the discussion. So I write a PR to add it ;-) In practice, I will likely also try to support all s390x buildbot workers:
And the LTO and LTO+PGO variants (Fedora Stable, Fedora Rawhide). |
pep-0011.txt
Outdated
@@ -120,6 +120,7 @@ Target Triple Notes Buildbot | |||
============================== =========================== ============================================== ======== | |||
aarch64-pc-windows-msvc https://buildbot.python.org/all/#/builders/729 Steve Dower | |||
powerpcle-unknown-linux-gnu glibc, clang https://buildbot.python.org/all/#/builders/435 Victor Stinner | |||
s390x-unknownlinux-gnu glibc, gcc https://buildbot.python.org/all/#/builders/223 Victor Stinner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s390x-unknownlinux-gnu glibc, gcc https://buildbot.python.org/all/#/builders/223 Victor Stinner | |
s390x-unknown-linux-gnu glibc, gcc https://buildbot.python.org/all/#/builders/223 Victor Stinner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so when I copy/paste an example, I pick the only one with a typo :-D I fixed the typo in the s390x platform, but also on the x86_64-unknownlinux-gnu
platform.
You will need to ask the SC as the PR was what we reviewed and approved. |
I created python/steering-council#122 to ask the SC. I convert this PR to a draft to make sure that it's not merged by mistake. |
The SC agrees with this addition, SC decision: python/steering-council#122 (comment) |
Merged. Thanks @brettcannon for the review (I fixed the platform format ;-)). |
No description provided.