Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 690: Added Post-History #2575

Merged
merged 2 commits into from
May 3, 2022
Merged

PEP 690: Added Post-History #2575

merged 2 commits into from
May 3, 2022

Conversation

Kronuz
Copy link
Contributor

@Kronuz Kronuz commented May 3, 2022

No description provided.

@Kronuz Kronuz requested a review from warsaw as a code owner May 3, 2022 21:49
pep-0690.rst Outdated
@@ -8,6 +8,7 @@ Type: Standards Track
Content-Type: text/x-rst
Created: 29-Apr-2022
Python-Version: 3.12
Post-History: `03-May-2022 <https://mail.python.org/archives/list/[email protected]/thread/IHOSWMIBKCXVB46FI7NGOC2F34RUYZ5Z/>`__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also add the discuss.python.org link.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Post-History: `03-May-2022 <https://mail.python.org/archives/list/[email protected]/thread/IHOSWMIBKCXVB46FI7NGOC2F34RUYZ5Z/>`__
Post-History: `03-May-2022 <https://discuss.python.org/t/pep-690-lazy-imports/15474>`__,
`03-May-2022 <https://mail.python.org/archives/list/[email protected]/thread/IHOSWMIBKCXVB46FI7NGOC2F34RUYZ5Z/>`__

@JelleZijlstra JelleZijlstra merged commit f1be4a3 into python:main May 3, 2022
@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented May 5, 2022

The stated purpose of the links in the Post-History header, as reflected in its description in PEP 1, PEP 12, and the template, as well as PEP 1's Discussing a PEP section, is to be a record of the PEP's canonical Discussions-To thread(s), rather than the announcement posts on Python-Dev, and this is not how it is used on the various other PEPs that now implement it (both those with discussions on Python-Dev and Discourse).

A link to just an announcement post that repeats the information in the PEP and the thread does not seem that useful to anyone but a SC reviewer doing a final conformance check, and in that singular case can be verified with a quick search. Furthermore, at PyCon US, the SC has indicated this requirement is slated to be changed in the near future, so at least until then, I'm not sure it makes sense to propose modifying this now.

Also, while to #2467, both the Discussions-To header link text, and the hover text on Post-History entries display the item type and venue without having to parse/visit the link, I'm concerned that seemingly "duplicate" entries may be confusing and cause extra burden for users, reviewers and tools reading this field, and that users not paying careful attention may more easily navigate to, or even reply to, something that is not the canonical discussion thread; even one such reply may generated many more, and thus bifurcate the discussion and make it harder to follow for users, developers, authors and SC members alike.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants