-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 691: Draft PEP for Simple JSON API #2578
Conversation
Co-authored-by: Cooper Lees <[email protected]> Co-authored-by: Donald Stufft <[email protected]> Co-authored-by: Pradyun Gedam <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on the PEP submission!
Can you also add a CODEOWNERS entry with @dstufft as the owner for this PEP?
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
I'm very happy to hear that this new API is moving forward, and looking forward to seeing it implemented. There are a handful of minor technical/rendering issues that can be fixed (inconsistent header order, obsolete BDFL-Delegate header, inconstant code-block syntax, incorrect syntax highlighting, dummy Discussions-To/Post-History, etc.), which I'm happy to help take care of. However, there are two more critical problems that should be resolved as soon as you can (and we really should have spotted prior to merge), and block me making such changes:
Also, while they are not strictly required and not as much a priority immediately, for the benefit of both reviewers and the community at large, you might to think about adding the relevant Suggested Sections from PEP 1, PEP 12 and the template, particularly "Security Implications", "Backwards Compatibility" and/or "Reference Implementation", and given the "answers" in the "FAQ" each closely fit the purpose of the standard "Rejected Ideas" section, I'd suggest retilting them accordingly. As a final sidenote, there's no need to include a non-working dummy link for |
No description provided.