PEP 670, 687: Update CODEOWNERS #2586
Conversation
CAM-Gerlach
changed the title
|
Thanks! |
|
@CAM-Gerlach, sorry I got the commit message wrong; I used the mobile app, and it has a slightly different workflow than the web UI. I'll pay better attention next time. |
|
No worries, its not a big deal. I've never used GitHub on mobile (web or app), but guess it doesn't use the PR title when merging, as is the case on desktop? |
The difference is that in when you click squash-and-merge in the web UI, you'll be able to edit the commit title and the commit body before actually mergin. On mobile, if you click the (very similar) squash-and-merge button, it'll merge right awa; if you want to edit the commit message, you'll have to do that before clicking squash-and-merge. |
|
Huh, its strange that it doesn't give you an opportunity to edit your merge commit message—does this happen with multi-commit squashes or can you not edit the long description either? What about regular merge commits? It particularly doesn't make much sense to me that mobile apps offer fewer features than what you could get by just opening the normal page in your mobile web browser, given companies have every incentive to push people to use them so they can vacuum up more data and push more notifications. As for why it didn't pick up the updated title, I see you answered that on the related Discourse thread and I ran into before but forgot about it. I find to be frankly inexplicably nonsensical behavior. But I guess it is what it is... |
It does, but you need to edit the commit message before you click squash and merge through a distinct, rather hidden modal (the settings cog midway through the PR, then "edit message", from memory). I also merge a lot of PRs on the GH mobile app, so have become used to this (less than ideal) workflow. The single commit behaviour has caught me out a few times as well.
Except that the GH website is rather poorly optimised for narrow vertical widths (iPhone) -- even split screen on my laptop isn't a great experience compared to when I'm at home with a monitor I can dedicate to the browser. But I rather digress... A |
|
Are you all talking about the mobile APP or WEBSITE? |
|
A |
|
App == crap :-( |
|
zap(app) |
No description provided.