Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 668: Address feedback and mark as accepted #2673

Merged
merged 2 commits into from
Jun 27, 2022
Merged

PEP 668: Address feedback and mark as accepted #2673

merged 2 commits into from
Jun 27, 2022

Conversation

pradyunsg
Copy link
Member

No description provided.

@pradyunsg
Copy link
Member Author

I'm not sure I understand why the linter does not like this URL.

@AA-Turner
Copy link
Member

@CAM-Gerlach the link is valid, do we need to update the regex pattern? From the lint job:

'Resolution' must be a direct thread/message URL..................................Failed
- hook id: validate-resolution
- exit code: 1

pep-0668.rst:14:Resolution: https://discuss.python.org/t/10302/44

A

@pradyunsg pradyunsg marked this pull request as ready for review June 27, 2022 21:49
@pradyunsg pradyunsg requested a review from dstufft as a code owner June 27, 2022 21:49
@pradyunsg
Copy link
Member Author

Figured it out -- the Resolution header needs to be at then end of the header list, to pass the lint check.

@pradyunsg pradyunsg mentioned this pull request Jun 27, 2022
Merged
@pradyunsg
Copy link
Member Author

This is ready for a merge from an editor, whenever someone has a moment to click the button. :)

@JelleZijlstra JelleZijlstra merged commit 6a83493 into python:main Jun 27, 2022
@pradyunsg pradyunsg deleted the pep-668-accepted branch June 27, 2022 22:32
@pradyunsg
Copy link
Member Author

Thanks @JelleZijlstra! ^>^

carljm added a commit to carljm/peps that referenced this pull request Jun 27, 2022
@carljm
Merge branch 'main' into 690v2
98ec76e 
* main: (47 commits)
  PEP 668: Address feedback and mark as accepted (python#2673)
  PEP-0691 Gramatical changes + `meta` key description under Project List (python#2677)
  PEP691: Mark Accepted + Grammar Fixes + Small Fix (python#2674)
  PEP 691: touch up (python#2668)
  PEP 650: Withdraw and move to Standards Track (python#2665)
  PEP 561: Mark as final (python#2663)
  PEP 660: Mark as Final (python#2664)
  PEP 615: Fix incorrect RFC link (python#2662)
  Multiple PEPs: Move Packaging PEPs to Standards Track and mark as Final (python#2657)
  PEP 671: Since it keeps getting asked about, add a para on deferreds (python#2661)
  Infra: Tweak PEP references to work on topic sub-index pages (python#2658)
  PEP 632: Remove `Topic: Packaging` header (python#2656)
  Infra: Make colour theme cycler button accessible (python#2619)
  PEP 593: Fix citation references (python#2640)
  PEP 553: Fix citation references (python#2639)
  PEP 668: Add PEP-Delegate (python#2654)
  PEP 693: Python 3.12 Release Schedule (python#2648)
  Add support for topic indices (python#2579)
  PEP691: Switch to a List for Project, Address more Feedback (python#2653)
  PEP 671: Add section on evaluation order (python#2652)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstufft dstufft Awaiting requested review from dstufft

@CAM-Gerlach CAM-Gerlach Awaiting requested review from CAM-Gerlach

@hugovk hugovk Awaiting requested review from hugovk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pradyunsg @AA-Turner @JelleZijlstra