Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 617: Mark as Final #3596

Merged
merged 1 commit into from
Dec 18, 2023
Merged

PEP 617: Mark as Final #3596

merged 1 commit into from
Dec 18, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Dec 18, 2023 •
edited by github-actions bot
Loading

  • Final implementation has been merged (including tests and docs)
  • PEP matches the final implementation
  • Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive (or canonical-pypa-spec, for packaging PEPs)

Helps #2872.

Also replace some old BPO links with their more accessible GitHub issue equivalents, and update some code block formatting.

📚 Documentation preview 📚: https://pep-previews--3596.org.readthedocs.build/

@hugovk hugovk mentioned this pull request Dec 18, 2023
Closed
12 tasks
lysnikolaou
lysnikolaou approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pablogsal pablogsal merged commit 228851c into python:main Dec 18, 2023
5 checks passed
@hugovk hugovk deleted the pep617-mark-as-final branch December 18, 2023 21:28
@hugovk hugovk mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugovk @lysnikolaou @pablogsal